Repository navigation
Conversation
curl_multi_select() only called SAVE_CURLM_ERROR() on failure, leaving a previous error code in place after a successful call, unlike the other multi-stack functions which reset it unconditionally. The CURLMOPT_PUSHFUNCTION branch of curl_multi_setopt() also returned early on an invalid callback before saving any error, silently keeping the previous error code even though this call failed too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curl_multi_select()only saved the multi-stack error code on failure, so a success left a previous error in place, unlike the other call sites. TheCURLMOPT_PUSHFUNCTIONbranch ofcurl_multi_setopt()also returned early on an invalid callback without saving any error. Both now go throughSAVE_CURLM_ERROR()whatever the outcome.To reproduce:
Before (8.4.26, 8.5.12):
7,7,7,7.After:
7,0,7,10.