Skip to content

Fix stream_socket_sendto() sending plaintext on a stream with TLS enabled - #25561

Open
lacatoire wants to merge 2 commits into
php:PHP-8.4from
lacatoire:fix/openssl-sendto-tls-PHP-8.4
Open

lacatoire wants to merge 2 commits into
php:PHP-8.4from
lacatoire:fix/openssl-sendto-tls-PHP-8.4

Conversation

@lacatoire

Copy link
Copy Markdown
Member

The openssl transport did not handle the send operation used by stream_socket_sendto(), so on a stream with TLS enabled the data went to the socket as plaintext, in the middle of the TLS records. The call reported success and the peer failed on its next read. The send now goes through the TLS session while encryption is active.

To reproduce:

$key = openssl_pkey_new(['private_key_bits' => 2048]);
$cert = openssl_csr_sign(openssl_csr_new(['commonName' => 'localhost'], $key), null, $key, 1);
openssl_x509_export($cert, $certPem);
openssl_pkey_export($key, $keyPem);
$pem = tempnam(sys_get_temp_dir(), 'pem');
file_put_contents($pem, $certPem . $keyPem);

$listener = stream_socket_server('tcp://127.0.0.1:0', context: stream_context_create(['ssl' => ['local_cert' => $pem]]));
$client = stream_socket_client('tcp://' . stream_socket_get_name($listener, false), context: stream_context_create(['ssl' => ['verify_peer' => false, 'verify_peer_name' => false]]));
$server = stream_socket_accept($listener);
stream_set_blocking($client, false);
stream_set_blocking($server, false);
do {
    $clientDone = stream_socket_enable_crypto($client, true, STREAM_CRYPTO_METHOD_TLS_CLIENT);
    $serverDone = stream_socket_enable_crypto($server, true, STREAM_CRYPTO_METHOD_TLS_SERVER);
} while ($clientDone === 0 || $serverDone === 0);

var_dump(fwrite($client, 'ENCRYPTED'));
var_dump(fread($server, 8192));
var_dump(stream_socket_sendto($client, 'SENT WITH SENDTO'));
var_dump(@fread($server, 8192));
unlink($pem);

Before (8.4.26, 8.5.12): the last fread() returns string(0) "".

After: it returns string(16) "SENT WITH SENDTO".

Comment thread ext/openssl/xp_ssl.c Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants