Repository navigation
Conversation
ZEND_CLONE stored the clone handler's return value unchecked. A handler that threw and returned NULL, as zend_ffi_free_clone_obj() does, left an IS_OBJECT result with a null pointer that ZEND_HANDLE_EXCEPTION released. The uri clone handler hit it once phpGH-25408 kept the opline of a delayed OOM, which caused its revert. The result is now left undefined.
iliaal
approved these changes
Nov 18, 2026
iliaal
left a comment
Member
There was a problem hiding this comment.
Nit: perhaps move the test to ext/ffi?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZEND_CLONE stored the clone handler's return value unchecked. A handler that threw and returned NULL, as zend_ffi_free_clone_obj() does, left an IS_OBJECT result with a null pointer that ZEND_HANDLE_EXCEPTION released. The uri clone handler hit it once GH-25408 kept the opline of a delayed OOM, which caused its revert. The result is now left undefined.