Repository navigation
Conversation
jnahmias
requested review from
NattyNarwhal and
SakiTakamachi
as code owners
November 18, 2026 22:11
Some ODBC drivers may report SQL_SUCCESS from SQLDescribeParam() while leaving sqltype as SQL_UNKNOWN_TYPE (0). Treat SQL_UNKNOWN_TYPE the same as a failed SQLDescribeParam() call and fall back to PDO parameter type inference instead of passing sqltype=0 to SQLBindParameter(). (cherry picked from commit 3120ca8)
jnahmias
force-pushed
the
pdo_odbc_param
branch
from
November 18, 2026 22:18
3120ca8 to
5b0d406
Compare
Author
|
Prior to this patch, After this patch, PDO_ODBC falls back to its existing parameter type inference logic, |
devnexen
reviewed
Nov 19, 2026
Leftover from debugging subsequent FreeTDS issue.
jnahmias
force-pushed
the
pdo_odbc_param
branch
from
November 19, 2026 14:17
5666a93 to
cdd6229
Compare
Author
|
feel free to squash if that makes more sense |
Member
|
Are the other values also invalid are is it just the type being |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some ODBC drivers, eg. FreeTDS, report SQL_SUCCESS from SQLDescribeParam() while leaving sqltype as SQL_UNKNOWN_TYPE (0).
Treat SQL_UNKNOWN_TYPE the same as a failed SQLDescribeParam() call and fall back to PDO parameter type inference instead of passing sqltype=0 to SQLBindParameter().