Repository navigation
mbstring: save the write offset before reallocating - #25570
Open
realFlowControl wants to merge 1 commit into
Open
realFlowControl wants to merge 1 commit into
realFlowControl wants to merge 1 commit into
Conversation
realFlowControl
requested review from
alexdowad and
youkidearitai
as code owners
November 18, 2026 22:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
mb_convert_buf_ensure()grows the conversion buffer, it calculates the write offset by subtracting two pointers into the old buffer after callingsafe_ferealloc(). If the allocation moves, those pointers are no longer valid. Subtracting them is undefined behavior even though neither is dereferenced.This PR saves the offset before reallocating, then add it to the new buffer’s base address.