Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MSVC C4047 warnings for pointer to bool conversions
This is an attempt to address a Windows CI failure seen in another PR, presumably caused by the runner image update to MSVC 14.52, which now warns on implicit pointer to bool conversions. The affected toolset is currently used in CI only for 8.6, but the fix applies to 8.4 as well. I created this PR to master, but it can be easily rebased or cherry-picked to another branch.
Failing job: https://github.com/php/php-src/actions/runs/44365638994/job/135018635177
Later jobs I looked at ran on an older MSVC version (14.51), which is why they passed.