Skip to content

Windows CI: Fix implicit pointer-to-bool conversions - #25577

Open
adapik wants to merge 1 commit into
php:masterfrom
adapik:fix-win-lazy-objects-c4047
Open

adapik wants to merge 1 commit into
php:masterfrom
adapik:fix-win-lazy-objects-c4047

Conversation

@adapik

@adapik adapik commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Fix MSVC C4047 warnings for pointer to bool conversions

This is an attempt to address a Windows CI failure seen in another PR, presumably caused by the runner image update to MSVC 14.52, which now warns on implicit pointer to bool conversions. The affected toolset is currently used in CI only for 8.6, but the fix applies to 8.4 as well. I created this PR to master, but it can be easily rebased or cherry-picked to another branch.

Failing job: https://github.com/php/php-src/actions/runs/44365638994/job/135018635177

Later jobs I looked at ran on an older MSVC version (14.51), which is why they passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant