Repository navigation
Conversation
Nothing moves before the first NOP: the opcodes stay in place and their shift is 0. Skip the leading reachable blocks without a NOP instead of copying them onto themselves one by one. The scan stops at the first block that is unreachable, keeps only a FREE, or does not start where the previous one ended, so the regular loop handles everything that can move. If the scan reaches the end, nothing moves at all (remove_nops is also set by passes that change an opcode without leaving a NOP), so return before allocating and clearing the shift list. The output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing moves before the first NOP: the opcodes stay in place and their shift is 0. Skip the leading reachable blocks without a NOP instead of copying them onto themselves one by one. The scan stops at the first block that is unreachable, keeps only a FREE, or does not start where the previous one ended, so the regular loop handles everything that can move. If the scan reaches the end, nothing moves at all (remove_nops is also set by passes that change an opcode without leaving a NOP), so return before allocating and clearing the shift list. The output is unchanged.
Measured on arm64 Linux VM (via Mac)