Repository navigation
Fix null handler generation for unspecialized VMs - #25579
Closed
LamentXU123 wants to merge 1 commit into
Closed
LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
devnexen
approved these changes
Nov 19, 2026
LamentXU123
added a commit
that referenced
this pull request
Nov 19, 2026
* PHP-8.6: Fix null handler generation for unspecialized VMs (#25579)
TimWolla
pushed a commit
to TimWolla/php-src
that referenced
this pull request
Nov 19, 2026
* PHP-8.5: Fix null handler generation for unspecialized VMs (php#25579)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #25571
Here we use a hack. Basically we when don't have the definition of $varient, php make it a empty string and we effectively have
ZEND_NULL_HANDLERfromZEND_NULL{$variant}_HANDLERwith a warning. But there is a case that it is cause TAILCALL entries to use ZEND_NULL_HANDLER instead of ZEND_NULL_TAILCALL_HANDLER.I am wondering why not just use the
gen_null_labelhelper anyways 😂.