Skip to content

Fix null handler generation for unspecialized VMs - #25579

Closed
LamentXU123 wants to merge 1 commit into
php:PHP-8.5from
LamentXU123:fixwarning
Closed

LamentXU123 wants to merge 1 commit into
php:PHP-8.5from
LamentXU123:fixwarning

Conversation

@LamentXU123

@LamentXU123 LamentXU123 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Fix #25571

Here we use a hack. Basically we when don't have the definition of $varient, php make it a empty string and we effectively have ZEND_NULL_HANDLER from ZEND_NULL{$variant}_HANDLER with a warning. But there is a case that it is cause TAILCALL entries to use ZEND_NULL_HANDLER instead of ZEND_NULL_TAILCALL_HANDLER.

I am wondering why not just use the gen_null_label helper anyways 😂.

LamentXU123 added a commit that referenced this pull request Nov 19, 2026
* PHP-8.6:
  Fix null handler generation for unspecialized VMs (#25579)
TimWolla pushed a commit to TimWolla/php-src that referenced this pull request Nov 19, 2026
* PHP-8.5:
  Fix null handler generation for unspecialized VMs (php#25579)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants