Repository navigation
doc: fix two dead links in the PCA and violin pages - #5885
Open
farisbasha wants to merge 1 commit into
Open
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
- ml-pca.md: scikit-learn moved the Diabetes dataset section from datasets/index.html to datasets/toy_dataset.html. - violin.md: the "Goodbye joyplots" post moved from serialmentor.com to clauswilke.com. Both old URLs return 404.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
No issue. This is a small docs link fix.
Description of change
Fixes two dead links in the published docs (this PR targets
doc-prod):doc/python/ml-pca.md: the "Diabetes" link pointed atscikit-learn.org/stable/datasets/index.html#diabetes-dataset, which returns 404. The section is now ondatasets/toy_dataset.html#diabetes-dataset.doc/python/violin.md: the "previously known as Joy Plot" link pointed atserialmentor.com/blog/2017/9/15/goodbye-joyplots, which returns 404. The post is now atclauswilke.com/blog/2017/09/15/goodbye-joyplots/.Demo
N/A (link targets only).
Testing strategy
No code changed. I checked with curl that both old URLs return 404, both new ones return 200, and the
#diabetes-datasetanchor exists on the new scikit-learn page.Guidelines