Skip to content

Nullify noLabels in StatefulMetric during clear() to prevent no-label inc to stop working - #972

Merged
dhoard merged 1 commit into
prometheus:mainfrom
iaco86:clear_fix
Sep 7, 2024
Merged

dhoard merged 1 commit into
prometheus:mainfrom
iaco86:clear_fix

Conversation

@iaco86

@iaco86 iaco86 commented Jul 19, 2024

Copy link
Copy Markdown
Contributor

Fixes #971

  • nullified volatile noLabels variable on clear()
  • enhanced testClearNoLabels

@fstab @dhoard @tomwilkie

…s increase to stop working

Signed-off-by: Iacopo Pace <iaco.pace@gmail.com>
@dhoard
dhoard merged commit b2db709 into prometheus:main Sep 7, 2024
@dhoard

dhoard commented Sep 7, 2024

Copy link
Copy Markdown
Contributor

@iaco86 Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StatefulMetric clear() invocation causes noLabels increase to stop reporting on collect()

2 participants