Skip to content

Fix the dev install to be absolute. - #2

Merged
bowlofeggs merged 1 commit into
pulp:masterfrom
bowlofeggs:dev_install
Oct 20, 2014
Merged

bowlofeggs merged 1 commit into
pulp:masterfrom
bowlofeggs:dev_install

Conversation

@bowlofeggs

Copy link
Copy Markdown

No description provided.

Comment thread pulp-dev.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since _ are a convention for private methods and this is accessing it publicly (not using self) consider renaming _manage_setup_pys to manage_setup_pys. (no underscore).

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I missed that when I moved it from Pulp's pulp-dev.py to it's environment. However, that is a comment for the pulp repo, not this one.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted another PR for this issue: pulp/pulp#1252

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this. I'm going to go ahead and merge this before the pulp PR goes in because it'll only affect me and I'm cool with it.

@bmbouter bmbouter self-assigned this Oct 20, 2014
@bmbouter

Copy link
Copy Markdown
Member

LGTM

@bowlofeggs
bowlofeggs merged commit 9268a1b into pulp:master Oct 20, 2014
@bowlofeggs
bowlofeggs deleted the dev_install branch October 20, 2014 18:27
asmacdo referenced this pull request in asmacdo/pulp_python Mar 31, 2016
Fixed tests and comments according to comments in pull-req pulp#121
werwty added a commit to werwty/pulp_python that referenced this pull request Dec 15, 2017
# This is the 1st commit message:

Add sync to pulp_python

# The commit message pulp#2 will be skipped:

# address pr feedback

# The commit message pulp#3 will be skipped:

# fix flake8

# The commit message pulp#4 will be skipped:

# add docstrings

# The commit message pulp#5 will be skipped:

# update delta calculation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants