Repository navigation
Reject non-string inputs in IP address validators - #579
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipv4()andipv6()currently accept integers, booleans, packed bytes and network tuples throughipaddress; strict CIDR and private-address options can instead raiseAttributeErroron those values. Reject non-string inputs before calling string methods oripaddress, returning the normalValidationErrorresult.Fixes #578.
The public
strannotations remain unchanged. The two runtime guards have narrowly scoped Pyright annotations because they protect callers that do not use static type checking.Validation on Windows / Python 3.12: the new non-string cases have 31 failures and 13 passes before the fix; afterward the full suite passes (1,560 tests). Tox lint, type, format and SAST checks pass, as does
git diff --check. Other Python versions were not run locally.Developed and validated with assistance from OpenAI Codex.