Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/validators/email.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def email(
if ipv6_address or ipv4_address:
if domain_part.startswith("[") and domain_part.endswith("]"):
# ref: RFC 5321
domain_part = domain_part.lstrip("[").rstrip("]")
domain_part = domain_part[1:-1]
else:
return False

Expand Down
17 changes: 17 additions & 0 deletions tests/test_email.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,20 @@ def test_rejects_newline_after_local_part(local_part: str):
def test_returns_failed_validation_on_idna_mapped_lookalike_domain(domain_part: str):
"""Test returns failed validation on email domains that only IDNA 2003 mapping makes valid."""
assert isinstance(email(f"user@{domain_part}"), ValidationError)


@pytest.mark.parametrize(
("value", "flag"),
[
("user@[[192.168.0.1]]", "ipv4_address"),
("user@[[192.168.0.1]", "ipv4_address"),
("user@[192.168.0.1]]", "ipv4_address"),
("user@[[[2001:db8::1]]]", "ipv6_address"),
],
)
def test_rejects_extra_brackets_around_address_literal(value: str, flag: str):
"""Test an address literal has exactly one pair of brackets (RFC 5321 4.1.3)."""
assert isinstance(email(value, **{flag: True}), ValidationError)
assert email(
f"user@[{'192.168.0.1' if flag == 'ipv4_address' else '2001:db8::1'}]", **{flag: True}
)