Repository navigation
Closed
Labels
3.14bugs and security fixesbugs and security fixesOS-windowsinfraCI, GitHub Actions, buildbots, Dependabot, etc.CI, GitHub Actions, buildbots, Dependabot, etc.type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Description
Excerpts from here #131526 (comment):
See e.g. https://github.com/python/cpython/actions/runs/14006628024/job/39221297660 and https://github.com/python/cpython/actions/runs/13954576580/job/39062383429#step:4:326.
After building, no more output can be seen.
This is interesting, because
cpython/.github/workflows/tail-call.yml
Lines 82 to 91 in ce79274
| - name: Native Windows (debug) | |
| if: runner.os == 'Windows' && matrix.architecture != 'ARM64' | |
| shell: cmd | |
| run: | | |
| choco install llvm --allow-downgrade --no-progress --version ${{ matrix.llvm }}.1.5 | |
| set PlatformToolset=clangcl | |
| set LLVMToolsVersion=${{ matrix.llvm }}.1.5 | |
| set LLVMInstallDir=C:\Program Files\LLVM | |
| ./PCbuild/build.bat --tail-call-interp -d -p ${{ matrix.architecture }} | |
| ./PCbuild/rt.bat -d -p ${{ matrix.architecture }} -q --multiprocess 0 --timeout 4500 --verbose2 --verbose3 |
clearly
./PCbuild/rt.bat is invoked. Maybe the reason is, because it is not used with backslashes like in| .\\PCbuild\\rt.bat |
The question then is, why
./PCbuild/build.bat is working ...
Linked PRs
Metadata
Metadata
Assignees
Labels
3.14bugs and security fixesbugs and security fixesOS-windowsinfraCI, GitHub Actions, buildbots, Dependabot, etc.CI, GitHub Actions, buildbots, Dependabot, etc.type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Activity
chris-eibl commentedon Mar 24, 2025
comment from @Fidget-Spinner #131526 (comment)
chris-eibl commentedon Mar 24, 2025
comment from @zooba #131526 (comment)
chris-eibl commentedon Mar 24, 2025
Yeah, I remember that pitfall having
exitin a batch file that is not invoked viacall. But then herecpython/.github/workflows/reusable-windows.yml
Lines 41 to 56 in ce79274
should be affected, too? But as @Fidget-Spinner noted,
reusable-windows.ymlusesshell: bashwhereastail-call.ymlusesshell: cmd. And in acmdprompt I definitely get an error for forward slashes.It's still not clear for me, why
./PCbuild/build.batis called called correctly, but as @zooba notes, there are manyexits in it!zooba commentedon Mar 24, 2025
Those are separate
run:elements. Each one of those is likely implemented by writing the contents ofrun:intorandomly_named.batand doingcmd /C .\randomly_named.bat, which then means any further batch files are nested within it. But becausebuild.batis the last one that runs, you don't notice if it exits all the way.In the other file, there are two batch files in the same
run:step, so you do notice if one exits the whole step early.chris-eibl commentedon Mar 24, 2025
Kudos to @zooba: prepending
callfixes the issue: https://github.com/python/cpython/actions/runs/14044831663/job/39323183797?pr=131690And reveals #131691, which I haven't noticed so far, because I only ran the full test suite for release or PGO builds ...
GH-131678: fix Windows tail-call CI does not run the test cases (GH-1…
Fidget-Spinner commentedon Mar 28, 2025
Thanks!