Repository navigation
Support "bpo-" in Misc/NEWS - #1
Conversation
| node = nodes.strong(text, text) | ||
| return [node] | ||
| content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__', | ||
| content = issue_re.sub(r'`\bpo-\2 <https://bugs.python.org/\2>`__', |
There was a problem hiding this comment.
\b ? I think you overwrote the \1 :-)
There was a problem hiding this comment.
That's on purpose as the first capture group is the prefix which doesn't matter. Probably should change the regex to use a non-capture group.
There was a problem hiding this comment.
Sure, you can either you use \1 or insert bpo-. But here you overwrote half the capture group by only deleting the 1 and not the \.
There was a problem hiding this comment.
Ah, you're right. Now fixed.
Make the prefix match non-capturing and fix a bug where a backslash was left into the substitution.
|
|
||
| ISSUE_URI = 'https://bugs.python.org/issue%s' | ||
| SOURCE_URI = 'https://hg.python.org/cpython/file/3.6/%s' | ||
| SOURCE_URI = 'https://github.com/python/cpython/tree/3.6/%s' |
There was a problem hiding this comment.
Shouldn't it be master rather than 3.6 on this branch?
There was a problem hiding this comment.
My patch for another issue will address this, I think 🤔
There was a problem hiding this comment.
I went ahead and updated here since I'm already changing it.
| node = nodes.strong(text, text) | ||
| return [node] | ||
| content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__', | ||
| content = issue_re.sub(r'`bpo-\1 <https://bugs.python.org/\1>`__', |
There was a problem hiding this comment.
I'd suggest making it https://bugs.python.org/issue\1 to avoid the redirect through https://www.python.org/sf/
No description provided.