Repository navigation
Conversation
reporting the stack limit of the main thread incorrectly. On platforms where pthread_getattr_np underreports the main thread's stack size, use RLIMIT_STACK for the main thread instead.
symbols for the Py check.
…doesn't depend on explicitly setting the stack size. It's correct for new threads regardless of that call.
|
!buildbot Alpine |
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 7b773d3 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F161749%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
aozmekik
left a comment
There was a problem hiding this comment.
Tested on Alpine 3.22 (musl) x86_64 and aarch64, debug build, against the merge base:
- configure sets
_Py_HAVE_UNRELIABLE_PTHREAD_GETATTR_NPon both. - Main thread
get_c_recursion_remaining(): 1450 -> 12650 withulimit -s 8192(same as glibc), 102250 with 64 MiB, and still 1450 with an unlimited stack. New threads stay at 1450. - test_lazy_import, test_typing, test_json, test_ast, test_compile, test_exceptions, test_pickle and test_threading pass; one of them fails on the merge base.
Nit: on musl configure prints checking whether pthread_getattr_np reports the main thread stack reliably... yes, since the cached value is the inverse. Also, cross builds default to no, so a musl cross build keeps the old limit unless ac_cv_unreliable_pthread_getattr_np=yes is passed. Might be worth defaulting from $host there.
This builds on @Yhg1s's #159376, trying some more things:
unreliable_pthread_getattr_npeven if configure runs with unlimited stack, by limiting it artificially.