Skip to content

gh-149584: _remote_debugging: Simplify page cache state - #162094

Merged
pablogsal merged 2 commits into
python:mainfrom
maurycy:rd-page-cache-state
Nov 16, 2026
Merged

pablogsal merged 2 commits into
python:mainfrom
maurycy:rd-page-cache-state

Conversation

@maurycy

@maurycy maurycy commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Remove the redundant valid flag (redundant since 661df25?) and unused next pointer from cache entries. Clear the cache by resetting page_cache_count instead of invalidating each entry.

@maurycy maurycy changed the title gh-149584: Simplify remote debugging page cache state gh-149584: _remote_debugging: Simplify page cache state Nov 16, 2026

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the cache cleanup!

@pablogsal
pablogsal merged commit 812bd87 into python:main Nov 16, 2026
61 of 62 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @maurycy for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Nov 16, 2026

Copy link
Copy Markdown

GH-162112 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 16, 2026
pablogsal pushed a commit that referenced this pull request Nov 16, 2026
…2094)

Use page_cache_count to identify active page cache entries. Remove the redundant validity flag, unused next pointer, and unused size macro.
(cherry picked from commit 812bd87)

Co-authored-by: Maurycy Pawłowski-Wieroński <maurycy@maurycy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants