Skip to content

gh-149584: _remote_debugging: Deduplicate AwaitedInfo construction - #162104

Merged
pablogsal merged 2 commits into
python:mainfrom
maurycy:rd-async-awaited-info
Nov 16, 2026
Merged

pablogsal merged 2 commits into
python:mainfrom
maurycy:rd-async-awaited-info

Conversation

@maurycy

@maurycy maurycy commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Use a shared helper to construct and append AwaitedInfo results for both asyncio APIs, removing duplicate allocs, cleanup. Test the result struct returned by both APIs.

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup!

@pablogsal pablogsal added the needs backport to 3.15 bugs and security fixes label Nov 16, 2026 — with ChatGPT Codex Connector
@pablogsal
pablogsal enabled auto-merge (squash) November 16, 2026 11:22
@pablogsal
pablogsal disabled auto-merge November 16, 2026 11:23
@pablogsal
pablogsal enabled auto-merge (squash) November 16, 2026 11:23
@pablogsal
pablogsal merged commit 6f049d3 into python:main Nov 16, 2026
62 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @maurycy for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-app

bedevere-app Bot commented Nov 16, 2026

Copy link
Copy Markdown

GH-162111 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 16, 2026
@maurycy
maurycy deleted the rd-async-awaited-info branch November 16, 2026 12:06
pablogsal pushed a commit that referenced this pull request Nov 16, 2026
…tion (GH-162104)

Use one helper to construct and append AwaitedInfo results for both asyncio APIs. Keep reference ownership and cleanup in the shared helper.
(cherry picked from commit 6f049d3)

Co-authored-by: Maurycy Pawłowski-Wieroński <maurycy@maurycy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants