Skip to content

gh-149584: _remote_debugging: Deduplicate frame parsing - #162105

Merged
pablogsal merged 1 commit into
python:mainfrom
maurycy:rd-frame-parser
Nov 16, 2026
Merged

pablogsal merged 1 commit into
python:mainfrom
maurycy:rd-frame-parser

Conversation

@maurycy

@maurycy maurycy commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Reuse parse_frame_buffer() for frames in copied stack chunks and remove unused output parameters. Doesn't change the existing remote reads, keeps the fallback behaviour.

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shared parser preserves the fallback behavior. Thank you!

@pablogsal
pablogsal enabled auto-merge (squash) November 16, 2026 12:07
@pablogsal
pablogsal merged commit bd1e9af into python:main Nov 16, 2026
64 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @maurycy for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @maurycy and @pablogsal, I could not cleanly backport this to 3.15 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker bd1e9afa74a38697c7e51df935b3348fa178391e 3.15

@bedevere-app

bedevere-app Bot commented Nov 16, 2026

Copy link
Copy Markdown

GH-162113 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 16, 2026
pablogsal added a commit that referenced this pull request Nov 16, 2026
…2105)

Use the shared frame parser for copied stack chunks. Remove unused output parameters while preserving remote reads and fallback behavior.

(cherry picked from commit bd1e9af)

Co-authored-by: Maurycy Pawłowski-Wieroński <maurycy@maurycy.com>
@maurycy
maurycy deleted the rd-frame-parser branch November 17, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants