Repository navigation
Conversation
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The punycode incremental encoder and decoder ran the whole-string transform on every chunk, so anything fed in more than one piece came out wrong ('a' then 'b' gave b'a-b-'). This makes them buffer until final=True, using BufferedIncrementalEncoder / BufferedIncrementalDecoder as suggested in the issue.
Behaviour changes:
Given these, I wouldn't backport it.
Docs: the issue says nothing in the docs mentions this, but the codecs table does say "Stateful codecs are not supported" for punycode. I updated that row.
Tests: new incremental tests in PunycodeTest, and punycode is no longer skipped in the incremental parts of test_basics, test_basics_capi and test_decoder_state. Removing those gates re-indents three blocks, so the diff is easier to read with whitespace hidden. StreamReader / StreamWriter are untouched, so punycode stays in broken_unicode_with_stateful for the stream block and test_seek.
gh-160155 has three xfail examples pinned to this issue. Whichever of the two lands second needs to drop them.
Used Claude to help with this.