Repository navigation
Honor declared import names in packages_distributions - #561
Open
Quinnod345 wants to merge 1 commit into
Open
Quinnod345 wants to merge 1 commit into
Quinnod345 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packages_distributions()skips PEP 794 declarations today. That can leave an explicitly declared package out of the mapping or return a stale name fromtop_level.txt.Read
Import-NameandImport-NamespacethroughPackageMetadatabefore trying the legacy sources. An empty declaration suppresses fallback. Dotted names map to their top-level package, and an exact overlap between the two fields raisesValueError. When metadata is unreadable, a distribution with no legacy contribution still gets skipped.Refs #526.
Four focused declaration tests fail on the upstream base and pass with this patch. The full suite passed 283 tests with one skip on each of CPython 3.11.14 and 3.14.7. Ruff, the docs build, and changed-line coverage passed.
I maintain Ponder. Its review caught the unreadable-metadata regression in the first patch. The native fixtures cover that path here.