Repository navigation
gh-7: Test configuration layer precedence and file loading - #443
Open
JunaidAhamed-7777 wants to merge 1 commit into
Open
JunaidAhamed-7777 wants to merge 1 commit into
JunaidAhamed-7777 wants to merge 1 commit into
Conversation
Member
|
Thanks, this looks great! Did you have anything else to add, or am I good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #7
Add tests for how PyManager loads settings from multiple config files. They check that the registry takes precedence over file layers and that an explicit override wins last. They also cover missing or malformed files, UTF-8 files with a BOM, and paths relative to the config file rather than the current directory.
The tests use temporary JSON files and mock the global config and registry loaders. No production code changes.
Validation:
python -m pytest tests/test_config.pyon Windows with Python 3.14.7: 74 passed, up from 67. The new tests caught six deliberately introduced loader regressions. Ruff andgit diff --checkpassed.