Repository navigation
Conversation
Author
|
The test workflows are waiting for maintainer approval. Could you approve the run when convenient? Local validation on this head passes 541 tests in each parser mode on Ruby 3.4.9; the Ruby 2.6.10 row suite also passes. The broader OS/Ruby matrix has not run yet. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSV::Row#to_hretrieves each value withself[key], which treats integer and range headers as column selectors. Numeric headers produced by a custom header converter therefore lose or misassign their values:Use header-only
fetch(key)in both hash-conversion paths. This preserves the first matching value for repeated headers and the existing block-call/key-transformation behavior discussed in #356. Regression tests cover integer and range headers with/without a block, the parsing example, and repeated integer headers with transformed output keys.Validation on macOS arm64:
main(afbee5e3548d38914706ae0de8a6cf421ba43187).ruby run-test.rbandCSV_PARSER_SCANNER_TEST=yes ruby run-test.rbeach pass 541 tests / 4,073 assertions.git diff --checkpass.rake warning:error rdocexits successfully; it reports the same two unresolvedARGF/dig_methods.rdocreferences as unchanged main.Other Ruby versions and operating systems were not tested locally.
AI use: OpenAI Codex prepared the patch, tests, and description, reviewed the existing duplicate-header discussion, and ran these checks.