Repository navigation
Conversation
hessenberg_to_real_schur used the outer variable n, which is -1 after the QR loop, in the branch that computes complex eigenvectors. The branch for complex eigenvectors now uses the block parameter k, like the branch for real eigenvectors. Co-authored-by: Claude Mythos 5.2 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matrix#eigensystemcan return wrong eigenvectors for a matrix of size 3 or more that has complex eigenvalues. The eigenvalues are correct.Since a3d4068, the branch for complex eigenvectors in
hessenberg_to_real_schurreads the outer variablen, which is -1 after the QR loop. The commit renamed the block parameter of the back-substitution loop fromntokto avoid a-wwarning, and the rename covered only the branch for real eigenvectors.Fix
The branch for complex eigenvectors now uses
k. With the example above,m * vectorisVector[(0.5+2.5i), (0.0-1.0i), (-1.0+0.0i)]and equalsvector * value.eigenvector_matrix_invis computed from the same eigenvectors. Before this change,Matrix[[0.0, -1.0, 2.0], [1.0, 0.0, 3.0], [0.0, 0.0, 5.0]].eigensystem.eigenvector_matrix_invraisesErrNotRegular; after,v * d * v_invequals the matrix.