Skip to content

Use the default tool cache path on self-hosted runners matching a GH-hosted runner image - #476

Merged
eregon merged 3 commits into
ruby:masterfrom
eregon:fix-self-hosted-matching
Mar 5, 2023
Merged

eregon merged 3 commits into
ruby:masterfrom
eregon:fix-self-hosted-matching

Conversation

@eregon

@eregon eregon commented Mar 5, 2023

Copy link
Copy Markdown
Member

Fixes #475

@eregon
eregon force-pushed the fix-self-hosted-matching branch from d8ff2b8 to a8c3dbe Compare March 5, 2023 13:47
* So it finds already-download prebuilt Ruby in the GH-hosted tool cache path
  on self-hosted, where $RUNNER_TOOL_CACHE is often different than on GH-hosted.
* See ruby#475.
* This relies on tc.find() looking up the env var every time:
  https://github.com/actions/toolkit/blob/1f4b3fac06/packages/tool-cache/src/tool-cache.ts#L522
@eregon
eregon force-pushed the fix-self-hosted-matching branch from a8c3dbe to af3f627 Compare March 5, 2023 13:48
@eregon
eregon merged commit 59b5745 into ruby:master Mar 5, 2023
@eregon
eregon deleted the fix-self-hosted-matching branch March 5, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 1.141.0 break my workflow

1 participant