Repository navigation
fix(integrations): validate github, gitlab, linear, slack, pagerduty, incident.io, sentry and datadog - #10071
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
All reported issues were addressed across 239 files
Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
Turn on auto-fix | Re-trigger cubic
[High impact] The changes since the previous review appear safe to merge. SummaryThis PR fixes request formats, field mappings, pagination, and outputs across eight integrations.
Reviews (3) · Last reviewed commit: "fix(integrations): keep latest-commit v2..." · Reviewed by Greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 240 files
Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 241 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
Turn on auto-fix | Re-trigger cubic
ff00204 to
bd61e0f
Compare
…l-call context and validate integrations against vendor specs
- keep the Linear project-status tool's display name so its docs anchor survives - pass Slack's comma-separated ID lists through the workflow-block mapper - reject '..' segments in GitHub content paths; only exact dot-segment GitLab ids - reject non-array commits in Sentry release create - mark nullable outputs (Linear dueDate/status, GitHub latest commit v2) - align descriptions with the vendor contracts (incident.io, Slack, GitHub, Linear) - drop a dead credential fallback the canonical-param check flags; fix test types
…fecycle timestamps nullable Inline the v2 commit output so the docs generator still documents it, and shrink the unused-exports baseline now that COMMIT_DATA_OUTPUT_PROPERTIES is imported.
bd61e0f to
1b22de1
Compare
Summary
Validates the GitHub, GitLab, Linear, Slack, PagerDuty, incident.io, Sentry and Datadog integrations against each vendor's official API spec, fixes what was wrong, and moves every block mapper in scope onto
mapperOperation(added in #10070) so the operation is read from the tool-call context.params.operation, which is undefined when a block runs as an Agent tool, in Pi or in Human-in-the-loop. Each operation's branch now runs on those paths too. Every newly live branch keeps the model's own args (viatoolCallArg), accepts already-typed values, and never overwrites an arg withundefined.check:mapper-operationbaseline shrinks for every block fixed here, and generated tool metadata and docs are regenerated.mpim:writescope, which the Sim Slack app does not request. Adding it would make every connected Slack user reconnect, so it is left for a product decision.Release notes
GitHub
starred=falsefor a repository you have not starred, instead of failing with "Not Found". It now queries GitHub's GraphQL API (viewerHasStarred).status=alland GitHub answered with zero runs.false) will now make the project private. New blocks default to "No change".true/false.#,?, or+reach the right file and ref.text_matches.GitLab
group%2Fproject, the form GitLab's docs show) now work on every project and SAML-link operation, instead of returning 404 Project Not Found..or..is now rejected before the request is sent. Before, it could rewrite a DELETE to hit the parent resource..trim is not a functionerror that failed the GitLab block when a numeric project/group ID was resolved from a reference.sha. Merges now succeed on groups and instances that require a SHA. A SHA saved earlier on Approve in the same block now also applies when that block is switched to Merge.expiresAt, the invitation's expiry is cleared again. Before, the empty value was dropped, or the call failed when no other field was set. Canvas behavior is unchanged.Linear
readAtfrom an agent now marks the notification read.status.hasNextPagewas true.Slack
get_team_profilevisibility,share_canvasaccess level,set_user_presencepresence, list limits, include/inclusive booleans, andedit_canvasoperation.hasMore=trueand anextCursorto continue from. A single Slack page larger than 10 MB now fails instead of loading.views.openAPI. A run with neither is rejected before the request is sent.U1,U2) as well as JSON arrays. Slack's documented limits now fail early with a clear error: 50 DND users, 1 ID for canvas revoke, 20 IDs for canvas share.PagerDuty
.,.., and empty values, and encode other characters. Before, a value like../userscould send the request to a different API path.totaloutput, which was always null before.incident.io
pagination_meta.afteris set. Setting Page Size or After fetches a single page of that size starting at that cursor, with no auto-pagination.creator(id/name/email plus the user/api_key/workflow/alert actor). Before, it was always empty. Follow-ups also returnassignee_teamandcategory.incident.updated) instead of "[object Object]".value_option,value_catalog_entry). Before, these came back as empty objects.once_for, incident modes, and delay as JSON arrays or objects (for example from another block's output) as well as JSON strings.Sentry
nextCursorandhasMore, so the block's existing Pagination Cursor / Has More outputs work. Before, they were always empty.metadata.nextCursorstill works./or exactly./..are now rejected before the request is sent (Create Deploy versions still percent-encode/). Surrounding whitespace in slugs and IDs is trimmed.Datadog
true/false) are read correctly. The model's own args are kept whenever the matching block field is blank. A model'scustomerImpacted=trueon Create Incident is honored.event.id_str(exact event ID), Get Incidentincluded(resources requested viainclude), and Get SLO Historyerrors(partial query errors returned with a 200).Review follow-ups
U1,U2) pass through to the tool instead of failing in the block...segments; GitLab rejects resource ids of exactly.or...Testing
params(modelArgs, { operation })without an operation in params, and were confirmed to fail on the pre-fix code.check:mapper-operation,check:explicit-any,check:tool-metadata,check:docs,check:docs-manifest,check:block-successors,check:deployment-config,check:canvas-sentences,check:test-patterns,check:utils,check:comment-hygiene,check:source-conventionsandcheck:integration-cataloglocally. CI runs type-check and the full suite.🤖 Generated with Claude Code