Skip to content

fix(integrations): validate dynamics 365, zoho desk, rippling, okta, sailpoint and snowflake - #10072

Merged
waleedlatif1 merged 11 commits into
stagingfrom
sweep2/v2
Nov 16, 2026
Merged

waleedlatif1 merged 11 commits into
stagingfrom
sweep2/v2

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Validates the Microsoft Dynamics 365, Zoho Desk, Rippling, Okta, SailPoint and Snowflake integrations against each vendor's official API spec, fixes what was wrong, and moves every block mapper in scope onto mapperOperation (added in #10070) so the operation is read from the tool-call context.

  • Every tool's endpoint, method, params, body, response parsing, outputs and auth/scopes was checked against the vendor's machine-readable spec. Claims that could not be verified were left unchanged.
  • Block mappers no longer read params.operation, which is undefined when a block runs as an Agent tool, in Pi or in Human-in-the-loop. Each operation's branch now runs on those paths too. Every newly live branch keeps the model's own args (via toolCallArg), accepts already-typed values, and never overwrites an arg with undefined.
  • Canvas requests for saved workflows are unchanged, except for the bug fixes listed below. No subBlock, operation, tool, param or output id was renamed or removed, and no OAuth scope was added.
  • The check:mapper-operation baseline shrinks for every block fixed here, and generated tool metadata and docs are regenerated.
  • Two new Okta tools are registered: okta_unlock_user and okta_list_user_groups.

Release notes

Microsoft Dynamics 365

  • Dynamics 365 CRM used as an Agent tool (or in Pi / Human-in-the-loop v2) now applies the block's field mapping, instead of failing with "Unsupported Dynamics 365 CRM operation: undefined" and falling back to raw params. Configured row values (resolution subject, close notes, status reasons, list/search options, qualification references, max results) are now sent.
  • On tool calls, the model's table (entitySetName), close outcome (won/lost), total-count flag, and search entities take precedence over the row's seeded Record Type / Outcome / Include Total Count defaults. The row values apply when the model omits them. List and record operations target the table the model names, and paging, select, filter, and close/qualify fields from the model are kept.
  • Search Records as an Agent tool now runs through the block's mapping. It uses the model's entities (a JSON string or an array) and otherwise searches all supported CRM tables, as before.
  • A blank Search Mode, Query Type, or Opportunity Outcome now falls back to its default (any / simple / won) instead of failing.
  • Search Records accepts PascalCase SearchEntity keys (Name, SelectColumns, ...) in entities, as in Microsoft's own example.
  • Saved canvas workflows send the same requests as before.

Zoho Desk

  • Create/Update Ticket: the Shared Departments param now tells agents to send objects ({id, type: READ_ONLY|READ_WRITE|RESTRICTED_ACCESS}) instead of bare department ID strings, which Zoho rejects. Saved canvas workflows are unaffected.

Rippling

  • Create/Update Custom Object Record now sends the Data fields as top-level record properties, as Rippling's API documents, instead of nesting them under a data key. Before, the fields were not applied.
  • Create/Update Custom Object Record now fails with a clear error when Data is not a JSON object. Before, malformed or non-object data was silently dropped: update sent an empty PATCH that reported success, and create sent only external_id. Valid object data is unchanged.
  • On tool calls (Agent, Pi, Human-in-the-loop), a model's true for All Or Nothing, Unique, Enable History, Include Object IDs, and Include Total Rows is now honored. It used to be sent as false.
  • On Create/Update Custom Setting tool calls, passing a data type (for example STRING) no longer fails the field mapping.
  • Filter, Expand, Order By, and Cursor values saved under a different operation are no longer sent to operations that don't support them.
  • Create Draft Hires and Update Supergroup Inclusion/Exclusion Members now accept payloads the older Data wand produced, already wrapped in draft_hires or Operations, instead of double-wrapping them.
  • List Custom Objects, Custom Object Fields, Custom Object Records, Object Categories, and the supergroup list operations now accept a Cursor. If a workflow has a Cursor value saved under another operation, that hidden value becomes visible on these operations and is sent.
  • List operations add a nextCursor output to pass back as Cursor. Bulk Delete adds deletedRecordIds. Get/List Worker, List Companies, and the business partner operations now return the objects requested via Expand.
  • Resource IDs equal to . or .., or containing /, are now rejected with a clear error instead of addressing a different endpoint.
  • Query Custom Object Records has a new optional advanced Order By field, sent as order_by. It takes one field name with optional asc or desc, for example name desc. Saved workflows send the same request as before.

Okta

  • Paginated Okta tools used as Agent tools (or in Pi / Human-in-the-loop) now honor the agent's after cursor. Before, every call returned page 1 again.
  • As Agent tools, Reset Password and Activate User now honor the agent's sendEmail=false and return the reset or activation link. Before, they always emailed the user. Deactivate User, Delete User, and Remove User from Application now honor the agent's sendEmail. Enroll Factor honors the agent's activate flag, and List Group Rules honors the agent's search keyword.
  • The Role Type, Factor Type, Factor Provider, and Sort Order dropdowns now start blank, so a new step or Agent tool row no longer defaults to Super Admin, SMS, Okta, or Ascending and overrides the agent's choice. Saved workflows keep their stored value. Agent tool rows that already stored SUPER_ADMIN keep it and must be changed by hand.
  • Create Group Rule accepts group and user ID lists sent as arrays.
  • IDs that are . or .., blank, or contain / or \ are now rejected before the request is sent, so they can no longer retarget a request (for example a membership DELETE) at the parent resource.
  • New operations: Unlock User and List User Groups.

SailPoint

  • Tool calls from Agents, Pi, and Human-in-the-loop now apply the block's field mapping. List Sources and Load Accounts no longer return 400 on string booleans. Limit, offset, and count typed in a tool row are coerced. A row's approval comment, CSV file, requested identities, search filters, and entitlement segmentation fields are sent instead of being silently dropped.
  • Get Access Request Config now sends the X-SailPoint-Experimental header that the v2 endpoint requires.
  • Canvas: filters hidden by the Review Item Type, Identity Scope, Access Model Segmentation, or Entitlement Segmentation selectors are no longer sent once deselected. This fixes "mutually exclusive" errors and 400s from a stale Include Unsegmented value.
  • Search: a comma-separated (non-JSON) Indices, Sort, or Search After value is passed to the tool instead of failing with "Invalid JSON".
  • Canvas: a list-operation Filters value left over after switching to a Search operation is no longer sent, so searches stop failing with "filters must be valid JSON". Likewise, a Search After value left over from a Search operation is no longer sent as the List Entitlements cursor. Agent tool calls are unchanged.

Snowflake

  • Snowflake tools on an Agent / Pi / Human-in-the-loop tool row now coerce numeric and JSON fields stored on the row (Maximum Rows, Timeout, Limit, Partition, Auto-Suspend, Rows, Bindings, and so on). Before, every such call failed with "must be an integer" errors.
  • Ask Cortex Analyst no longer erases a semantic source the model provided when the Semantic Source dropdown points at an empty field. On the canvas, a dropdown/field mismatch with exactly one filled source now uses that source instead of failing.
  • List Query History: user and warehouse filters now match quoted, case-sensitive names (for example "Analytics WH" or "jdoe@corp.com"). Before, they were sent without their quotes and matched nothing. Unquoted names are unchanged.
  • Load Data now runs with the block's Database and Schema as the session context. Unqualified stage and file format references, such as @RAW_STAGE/path, now resolve in the target schema instead of the user's default namespace, or instead of failing when the user has no default namespace.
  • Alter Warehouse, Unload Data, and List Query History ignore a null or string false flag coming from a direct tool call. They no longer emit AUTO_RESUME = FALSE, OVERWRITE/SINGLE/HEADER = TRUE, or an error-only filter that nobody asked for. Canvas runs are unchanged.
  • Unload Data and Alter Warehouse: the Overwrite, Header, Single File, and Auto Resume switches now accept case-variant strings such as TRUE or true from block references or agent tool calls. Before, an Overwrite value of TRUE produced OVERWRITE = FALSE.
  • Execute SQL and other statement reads now report truncated: true when Snowflake returns code 391908 (result set too large, response incomplete). Before, such a single-partition response was reported as truncated: false.

Review follow-ups

  • Okta List User Groups now paginates (after/Limit) and returns nextCursor and hasMore. Before, it returned only the first page.
  • Dynamics 365 List Owners and Assign Record now work from Agent, Pi and Human-in-the-loop tool rows: the owner type and owner ID fields render on the row. Before, every tool call failed.
  • Dynamics 365 Close Opportunity still requires an outcome: a blank outcome fails rather than closing the deal as won.
  • Rippling Create/Update Custom Object Record now send the documented flat body instead of wrapping fields in data. Create rejects empty data.
  • Rippling list operations that gained cursor pagination now send the Cursor field when it's set.

Testing

  • Each integration (or batch of blocks) was fixed by one agent and then reviewed by independent adversarial reviewers until it came back clean. Integrations got a vendor-spec/auth lens and a canvas-vs-tool-call/backward-compat lens; batches got the canvas-vs-tool-call lens.
  • Regression tests call each mapper the way the Agent path does, params(modelArgs, { operation }) without an operation in params, and were confirmed to fail on the pre-fix code.
  • Ran the touched test files, biome, check:mapper-operation, check:explicit-any, check:tool-metadata, check:docs, check:docs-manifest, check:block-successors, check:deployment-config, check:canvas-sentences, check:test-patterns, check:utils, check:comment-hygiene, check:source-conventions and check:integration-catalog locally. CI runs type-check and the full suite.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 16, 2026 3:29am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 150 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/rippling/utils.ts Resolved
Comment thread apps/sim/tools/rippling/list_teams.ts Resolved
Comment thread apps/sim/blocks/blocks/rippling.ts Resolved
Comment thread apps/sim/tools/okta/list_user_groups.ts Resolved
@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The PR appears safe to merge; no new blocking issue was found.

Summary

Updates field mapping and request building across six integrations.

  • Dynamics 365 tool calls use the operation and values supplied by the caller.
  • Okta tool calls honor more model choices and include two new user tools.
  • Rippling custom records send field values in the shape its API expects.
  • Rippling list calls pass cursors and return more of the requested data.
  • SailPoint tool calls map their inputs and canvas requests drop fields hidden by selectors.
  • Snowflake tool calls convert row values and preserve more request and result details.
  • Zoho Desk ticket tools describe shared departments with an ID and access type.

No new actionable issues were found. Rippling’s previously missing nextCursor documentation is present. waleedlatif1 explicitly chose to reject a blank Dynamics opportunity outcome because defaulting to won could close a deal incorrectly; Greptile withdrew that finding.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Saved row values and model arguments] --> B[Decode stored values]
  B --> C[Map using selected operation]
  C --> D[Merge mapped values over original arguments]
  D --> E[Build vendor request]
  F[Canvas inputs] --> G[Map using stored operation]
  G --> E
Loading

Reviews (7) · Last reviewed commit: "fix(microsoft-dynamics-365): keep a blan..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 150 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/okta/list_user_groups.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 150 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 150 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Follow-up on the Close Opportunity outcome: I restored staging's params.opportunityOutcome ?? 'won' on the canvas. A blank outcome now fails with "Outcome is required" instead of closing the deal as won. The dropdown always seeds won, so a blank only arrives when something writes '' programmatically. In that case, closing as won by assumption would record a business outcome nobody chose, so failing is the safer behavior. The test pins the failure.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 150 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

…l-call context and validate integrations against vendor specs
…ho desk and snowflake

- dynamics 365: blank canvas Outcome falls back to won
- okta: list_user_groups pages with after/limit and returns nextCursor/hasMore
- rippling: nextCursor output inlined (nullable) so docs list it; create record rejects blank data; cursor placeholder names the query cursor
- zoho desk: restore sharedDepartments maxItems 10 on update_ticket
- test types: narrow the okta url builder and snowflake mapper in new tests
List Owners and Assign Record read ownerType/ownerId, which are block-only
fields a tool row never rendered or stored, so every agent, Pi and HITL call
failed with 'Owner type is required'. Mark both user-only so rows store them;
canvas behavior is unchanged.
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 150 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

# Conflicts:
#	apps/sim/tools/generated/tool-metadata.ts
#	apps/sim/tools/generated/tool-outputs.ts
#	scripts/check-mapper-operation.baseline.json
@waleedlatif1
waleedlatif1 merged commit 1dc07de into staging Nov 16, 2026
30 of 32 checks passed
@waleedlatif1
waleedlatif1 deleted the sweep2/v2 branch November 16, 2026 04:00

This branch was successfully deployed

1 active deployment
Preview — 26e3c41a Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant