Repository navigation
fix(integrations): validate dynamics 365, zoho desk, rippling, okta, sailpoint and snowflake - #10072
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
All reported issues were addressed across 150 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[High impact] The PR appears safe to merge; no new blocking issue was found. SummaryUpdates field mapping and request building across six integrations.
No new actionable issues were found. Rippling’s previously missing
|
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 150 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
c02dc07 to
0e98f44
Compare
367f575 to
6bde084
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
Follow-up on the Close Opportunity outcome: I restored staging's |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 150 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
…l-call context and validate integrations against vendor specs
…ho desk and snowflake - dynamics 365: blank canvas Outcome falls back to won - okta: list_user_groups pages with after/limit and returns nextCursor/hasMore - rippling: nextCursor output inlined (nullable) so docs list it; create record rejects blank data; cursor placeholder names the query cursor - zoho desk: restore sharedDepartments maxItems 10 on update_ticket - test types: narrow the okta url builder and snowflake mapper in new tests
List Owners and Assign Record read ownerType/ownerId, which are block-only fields a tool row never rendered or stored, so every agent, Pi and HITL call failed with 'Owner type is required'. Mark both user-only so rows store them; canvas behavior is unchanged.
…ad of assuming won
d3409a8 to
6422316
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 150 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
# Conflicts: # apps/sim/tools/generated/tool-metadata.ts # apps/sim/tools/generated/tool-outputs.ts # scripts/check-mapper-operation.baseline.json
Summary
Validates the Microsoft Dynamics 365, Zoho Desk, Rippling, Okta, SailPoint and Snowflake integrations against each vendor's official API spec, fixes what was wrong, and moves every block mapper in scope onto
mapperOperation(added in #10070) so the operation is read from the tool-call context.params.operation, which is undefined when a block runs as an Agent tool, in Pi or in Human-in-the-loop. Each operation's branch now runs on those paths too. Every newly live branch keeps the model's own args (viatoolCallArg), accepts already-typed values, and never overwrites an arg withundefined.check:mapper-operationbaseline shrinks for every block fixed here, and generated tool metadata and docs are regenerated.okta_unlock_userandokta_list_user_groups.Release notes
Microsoft Dynamics 365
entitySetName), close outcome (won/lost), total-count flag, and search entities take precedence over the row's seeded Record Type / Outcome / Include Total Count defaults. The row values apply when the model omits them. List and record operations target the table the model names, and paging, select, filter, and close/qualify fields from the model are kept.Name,SelectColumns, ...) inentities, as in Microsoft's own example.Zoho Desk
{id, type: READ_ONLY|READ_WRITE|RESTRICTED_ACCESS}) instead of bare department ID strings, which Zoho rejects. Saved canvas workflows are unaffected.Rippling
datakey. Before, the fields were not applied.external_id. Valid object data is unchanged.truefor All Or Nothing, Unique, Enable History, Include Object IDs, and Include Total Rows is now honored. It used to be sent as false.STRING) no longer fails the field mapping.draft_hiresorOperations, instead of double-wrapping them.nextCursoroutput to pass back as Cursor. Bulk Delete addsdeletedRecordIds. Get/List Worker, List Companies, and the business partner operations now return the objects requested via Expand..or.., or containing/, are now rejected with a clear error instead of addressing a different endpoint.order_by. It takes one field name with optionalascordesc, for examplename desc. Saved workflows send the same request as before.Okta
aftercursor. Before, every call returned page 1 again.sendEmail=falseand return the reset or activation link. Before, they always emailed the user. Deactivate User, Delete User, and Remove User from Application now honor the agent'ssendEmail. Enroll Factor honors the agent'sactivateflag, and List Group Rules honors the agent's search keyword.SUPER_ADMINkeep it and must be changed by hand..or.., blank, or contain/or\are now rejected before the request is sent, so they can no longer retarget a request (for example a membership DELETE) at the parent resource.SailPoint
X-SailPoint-Experimentalheader that the v2 endpoint requires.Snowflake
"Analytics WH"or"jdoe@corp.com"). Before, they were sent without their quotes and matched nothing. Unquoted names are unchanged.@RAW_STAGE/path, now resolve in the target schema instead of the user's default namespace, or instead of failing when the user has no default namespace.falseflag coming from a direct tool call. They no longer emitAUTO_RESUME = FALSE,OVERWRITE/SINGLE/HEADER = TRUE, or an error-only filter that nobody asked for. Canvas runs are unchanged.TRUEortruefrom block references or agent tool calls. Before, an Overwrite value ofTRUEproducedOVERWRITE = FALSE.truncated: truewhen Snowflake returns code 391908 (result set too large, response incomplete). Before, such a single-partition response was reported astruncated: false.Review follow-ups
after/Limit) and returnsnextCursorandhasMore. Before, it returned only the first page.data. Create rejects empty data.Testing
params(modelArgs, { operation })without an operation in params, and were confirmed to fail on the pre-fix code.check:mapper-operation,check:explicit-any,check:tool-metadata,check:docs,check:docs-manifest,check:block-successors,check:deployment-config,check:canvas-sentences,check:test-patterns,check:utils,check:comment-hygiene,check:source-conventionsandcheck:integration-cataloglocally. CI runs type-check and the full suite.🤖 Generated with Claude Code