Repository navigation
fix(integrations): validate twilio, sendgrid, resend, mailgun, discord, telegram and whatsapp - #10073
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[High impact] The PR appears safe to merge; no blocking new issue was established. SummaryThis PR fixes integration inputs and outputs across eight messaging and email services.
Reviews (4) · Last reviewed commit: "chore: regenerate tool metadata and mapp..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 111 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 111 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 111 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…l-call context and validate integrations against vendor specs
- twilio: trim account SID and From number once, mark sender/recipient outputs nullable, make From optional on the block when a Messaging Service is used - discord: truncate fractional limits, reject more than one message cursor, mark nullable outputs - telegram: only keep spoiler spans, drop NUL so input cannot alias a protected segment, mark optional animation fields, fall back to model poll options when the stored field is blank - resend: clamp list limit to 1-100, sentence covers segment or audience, nullable broadcast outputs - mailgun: clamp events limit to 300 - twilio voice: nextPageToken nullable - fix test-types errors in twilio and whatsapp tests
32446d8 to
c68bc75
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Validates the Twilio, Twilio Voice, SendGrid, Resend, Mailgun, Discord, Telegram and WhatsApp integrations against each vendor's official API spec, fixes what was wrong, and moves every block mapper in scope onto
mapperOperation(added in #10070) so the operation is read from the tool-call context.params.operation, which is undefined when a block runs as an Agent tool, in Pi or in Human-in-the-loop. Each operation's branch now runs on those paths too. Every newly live branch keeps the model's own args (viatoolCallArg), accepts already-typed values, and never overwrites an arg withundefined.check:mapper-operationbaseline shrinks for every block fixed here, and generated tool metadata and docs are regenerated.Release notes
Twilio
fromNumberandtoNumberoutputs now return the sender and recipient Twilio reports. Before, they were always empty.Twilio Voice
transcriptionText,transcriptionStatus, andtranscriptionPricenow come from the requested recording's own transcription. Before, the account-level list ignored the RecordingSid filter, so these fields could hold the newest transcription on the account, often from a different call. Recordings with no transcription now return these fields empty.file,transcriptionPrice, andtranscriptionPriceUnitoutputs now appear in the block's output picker.nextPageTokenoutput for paging past the first page. The agent can now set the date filters and page size.durationoutput is now a number (or empty), not Twilio's raw string.SendGrid
.or..) are now rejected instead of being sent to another endpoint. Valid IDs are unchanged.legacy,dynamic, andlegacy,dynamic. The request default is unchanged.Resend
unsubscribedto true now unsubscribes the contact. Before, a boolean true was turned into false, so agent-driven unsubscribes re-subscribed the contact. Canvas dropdown behavior is unchanged.2026-11-16T09:00:00-08:00). Before, these were rejected with "Invalid request data".audience_id. Audience ID is no longer marked required for this operation.replyTooutput is now declared as an array of addresses, which matches what Resend returns. The value itself is unchanged./or equal to..is now rejected instead of being used to reach a different API path.Mailgun
listAddressandaddress, it adds the member it named to the list it named. Canvas requests are unchanged.subscribed=yes.fromandsubjectoutputs for sent messages retrieved by storage key, where Mailgun returnsFrom/Subject.?and#inside it. Valid values build the same request URL as before.Discord
mute: false/deaf: false, which unmuted and undeafened the member on every rename.true(for example from a block output reference) now archives the thread. It used to sendarchived: false./channels/{channel_id}/messages/pins/{message_id}endpoint instead of the deprecated/pinsone. Behavior is the same.deleteMessageSeconds) again, instead of deleting no messages.Telegram
<,>, or&(for example "Latency < 200ms & rising") now send. Before, Telegram rejected them with "can't parse entities". Supported HTML tags such as<b>still pass through.[docs](https://x.com/a_b_c)keeps its URL), and no longer applies**/*emphasis inside code spans.<b>for bold") is now sent as escaped literal text. Before, Telegram rejected the message with a parse error. This applies to message text, edits, and media captions.videoandanimationoutputs (file_id, dimensions, duration, thumbnail, and so on). Theformatoutput never held data and is now documented as a legacy key.WhatsApp
mediaIdoutput (returned when a file is uploaded as part of the send) in its tool output schema. Runtime behavior for saved workflows does not change.Review follow-ups
<span>(onlytg-spoilerspans are kept) instead of the whole send failing, and strips NUL characters from message text.Testing
params(modelArgs, { operation })without an operation in params, and were confirmed to fail on the pre-fix code.check:mapper-operation,check:explicit-any,check:tool-metadata,check:docs,check:docs-manifest,check:block-successors,check:deployment-config,check:canvas-sentences,check:test-patterns,check:utils,check:comment-hygiene,check:source-conventionsandcheck:integration-cataloglocally. CI runs type-check and the full suite.🤖 Generated with Claude Code