Repository navigation
fix(integrations): validate shopify, brex, ramp, zoom, calendly, cal.com, typeform, webflow and wordpress - #10074
Merged
Merged
Conversation
…l-call context and validate integrations against vendor specs
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[High impact] The changes since the previous review appear safe to merge. SummaryUpdates nine integrations with fixes for tool-call inputs, request paths, defaults, filters, and output descriptions.
Reviews (2) · Last reviewed commit: "fix(integrations): address v4 review fin..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 139 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
- wordpress: reject unparseable term IDs instead of dropping them, map date explicitly, type search ids as number | string - typeform: keep filename whitespace when building the file download URL - brex: reject a limit buffer percentage outside Brex's 0-100 integer range - calcom: type bookingUrl, hidden and ownerId on event type responses - tests: call tool builders through ToolConfig instead of a type assertion
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
1 task done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validates the Shopify, Brex, Ramp, Zoom, Calendly, Cal.com, Typeform, Webflow and WordPress integrations against each vendor's official API spec, fixes what was wrong, and moves every block mapper in scope onto
mapperOperation(added in #10070) so the operation is read from the tool-call context.params.operation, which is undefined when a block runs as an Agent tool, in Pi or in Human-in-the-loop. Each operation's branch now runs on those paths too. Every newly live branch keeps the model's own args (viatoolCallArg), accepts already-typed values, and never overwrites an arg withundefined.check:mapper-operationbaseline shrinks for every block fixed here, and generated tool metadata and docs are regenerated.cloud_recording:delete:meeting_recordingscope, which the Zoom provider does not request yet. Adding it would make connected Zoom users reconnect, so the scope change is left for a product decision. Single-file deletes work as before.Release notes
Shopify
Brex
accountType(BREX_CLASSICorBREX_EMPOWER). Before, it was always null.Ramp
Zoom
settings.auto_recording='none'. A numeric meeting ID from the model is accepted. Values the model sends under the tool's own param names (type,topic,from,to,action) still apply when the row field is empty.2, but an empty value still creates a Scheduled meeting.settings.auto_recording='none'. Zoom's default on create is already none, so the resulting meeting is the same. Canvas requests are unchanged./or contain//; any/for past participants). Before, these requests failed with "meeting does not exist". Numeric IDs and plain UUIDs are unchanged.cloud_recording:delete:meeting_recordingscope. Sim's Zoom OAuth connection does not request that scope yet, so this path fails for OAuth users. Deleting one file by Recording ID works. Once the scope is added, existing Zoom connections must reconnect before delete-all will work.Calendly
active=false, and Calendly returned only inactive event types.{kind, location}) and Questions and Answers, so you can book event types that need a location set by the invitee or answers to required booking questions.?,#, or similar is now encoded in the request path, and.or..is rejected. Valid UUIDs, URIs, andmework as before.Cal.com
dataandpagination, where the response actually lives (for example<calcom.data.uid>). Event type outputs also listbookingUrl,hidden, andownerId...or a separator).Typeform
responseType, for examplepartial,completed) that returns partial responses. When it is set, the Completed filter is not sent. Typeform's own default, completed only, is what the existing "All Responses" option has always returned./or\, or is.or.., is now rejected before the request, instead of being sent to a different Typeform endpoint. Surrounding whitespace in a Form ID is trimmed./fields, screens, and/settings/language, which Typeform rejects..or..and returns a 400 error. Before, such a value was silently resolved to another Typeform API route. No real Typeform ID or filename has this shape, so saved workflows are unaffected.Webflow
fieldDatais parsed for create/update. Before, these steps ran only on the canvas..,.., or contains/is rejected instead of sending the request to a different Webflow path.NaN.id,fieldData,lastPublished, ...) for tag references. Output keys are unchanged.WordPress
username,first_name,last_name,email, androlesoutputs are now marked optional (edit context only), because WordPress omits them in the default view context. Requests and output keys are unchanged.?and#are encoded instead of altering the request./posts/NaN.context=editon list users/comments.Review follow-ups
Testing
params(modelArgs, { operation })without an operation in params, and were confirmed to fail on the pre-fix code.check:mapper-operation,check:explicit-any,check:tool-metadata,check:docs,check:docs-manifest,check:block-successors,check:deployment-config,check:canvas-sentences,check:test-patterns,check:utils,check:comment-hygiene,check:source-conventionsandcheck:integration-cataloglocally. CI runs type-check and the full suite.🤖 Generated with Claude Code