Repository navigation
fix(blocks): read the mapper operation from the tool-call context in aws and infra blocks - #10075
Merged
Merged
Conversation
…l-call context and validate integrations against vendor specs
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[High impact] The PR appears safe to merge. SummaryUpdates AWS and infrastructure block mappers to read the selected operation from tool-call context.
Reviews (2) · Last reviewed commit: "fix(blocks): keep model format, recursiv..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 80 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…tool calls - tinybird append: fall back to the model's format before the csv default - sftp mkdir: fall back to the model's recursive before the default - cloudwatch get_metric_statistics: accept and normalize extendedStatistics from either source - azure data explorer ingest: an explicitly disabled Run in background stays off - cloudwatch/codepipeline tests: narrow the mapper so test-types passes
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves every block mapper for the AWS and infrastructure blocks onto
mapperOperation(added in #10070), so the operation is read from the tool-call context. These integrations were validated in earlier sweeps, so this PR covers the mapper fix plus any defects found while tracing it.params.operationis undefined when a block runs as an Agent tool, in Pi or in Human-in-the-loop, so until now these mappers skipped their per-operation renames and coercions on those paths. Each newly live branch keeps the model's own args (viatoolCallArg), accepts already-typed values, and never overwrites an arg withundefined.check:mapper-operationbaseline shrinks for every block fixed here, and generated tool metadata and docs are regenerated.Release notes
Athena
maxResultsstrings are coerced to numbers andresultReuseEnabledstrings to booleans. Saved canvas workflows are unchanged.Azure Data Explorer
modeandasyncvalues. Blank optional strings are dropped, andreadOnly/ifExistsstrings are normalized to booleans. Saved canvas workflows are unchanged.Cloudflare
purge_everything=truedrops the files/tags/hosts/prefixes targets, which Cloudflare rejects in combination with it. Update DNS Record drops blank content/name/comment. Model-supplied record types and other aliased params are preserved. Saved canvas workflows are unchanged.CloudFormation
CloudTrail
CloudWatch
CodePipeline
maxResults, pipeline version, abandon) and no longer fails with "Invalid CodePipeline operation: undefined". Approve/Reject sends the model's token, status, and summary, and Disable Stage Transition sends the model's reason. Saved canvas workflows are unchanged.CrowdStrike
filter,limit,sort,offset,q,compositeIds,ids,deviceIds,indicators,comment, and others) was cleared to undefined. Host and host-group actions now send the model'sactionName, and Delete Indicators sends the model's filter. Saved canvas workflows are unchanged.Dagster
Daytona
url/pathfor Git clone are kept.DynamoDB
projectionExpression,indexName, andconsistentReadare kept.Dynatrace
AFFECTED, the only value Dynatrace accepts for unmute.evaluationTypetoAGGREGATEwhen neither the row nor the model sets it.enabledparam, unless the model passes a boolean.Fivetran
paused=trueorpaused=false, and clear every other update setting, matching the canvas. Before, the operation was not seen on tool calls, so the update tool was sent without the paused state.syncFrequency,paused,runSetupTests, trust flags,force,limit, list_users filters, and similar fields. Model-suppliedservice,config,name,schemas,enabled, andtablesare still forwarded unchanged for create destination, create group, update schema config, update connection schema, and update connection table. Saved canvas workflows are unchanged.Google BigQuery
newDatasetId,datasetLocation,newTableId). Before, those fields were ignored on tool calls.Grafana
queries,folderUid,parentUid, andruleGroupare kept when the row leaves those fields blank. Before, the block mapping could leave them out or replace them.AWS IAM
maxItemsis parsed to an integer (sent asmaxResultsfor simulate), and tags are serialized on Create User/Role. Update Access Key keeps the model's status when the row has none.AWS Identity Center
maxResultsto an integer and sends the row's account filter asaccountIdon List Account Assignments. The model'saccountIdis kept when no filter is stored.Infisical
Jupyter
Lambda
Logfire
LogRocket
Modal
maxTokens,temperature, andtopPas numbers when the model passes them as strings. Call Function keeps the URL the model supplies.New Relic
PlanetScale
statefilter the model sent. Before, it was overwritten with undefined.Railway
prDeploys,ephemeral,skipInitialDeploys,stageInitialChanges,skipDeploys) as booleans. Before, they went to Railway as the stringstrue/false. The model's own args are still forwarded unchanged.RDS
S3
get_object. Before, every non-get_objectcall failed the mapper with "S3 Object URL is required" and went to the tool unmapped. Nowdelete_objectsuses the model'skeys,presigned_urlaccepts the model'smethodandcontentType,put_objectnormalizes the attached file and keepsmetadata, andlist_buckets/head_object/create_bucketkeep the model'sprefix,continuationToken,versionId, andacl.AWS Secrets Manager
maxResults,recoveryWindowInDays, andautomaticallyAfterDaystyped as text are converted to numbers. TheforceDelete,rotateImmediately, andincludePlannedDeletiontoggles become booleans. JSONtagsandtagKeysare parsed for Tag/Untag Resource.Amazon SES
pageSizeis converted to a number on the list operations. ThereputationMetricsEnabledandsendingEnabledtoggles become booleans on Create Configuration Set. JSONemailTagsare parsed.SFTP
recursive=true). Before, it always sentrecursive=false. It honors the "Create Parent Directories" setting (default on).Splunk
triggerActions,forceDispatch,enableLookups,allowPartialResults,addSummaryToMetadata) become real booleans, and numeric fields (count,offset,maxCount,autoCancel, and others) are converted to numbers.Amazon SQS
delaySeconds,maxNumberOfMessages, andwaitTimeSecondsare validated and converted to numbers. JSON fields under tool names (data,messageAttributes,messageAttributeNames, and others) are parsed.SSH
path,remotePath,workingDirectory,type,mode,permissions, andrecursivearguments are kept, andmaxSize,interpreter, andrecursiveget their defaults and coercion. Saved canvas workflows are unchanged.AWS Systems Manager
names,instanceIds,targets,parameters, andfiltersare parsed,maxResultsandexecutionTimeoutSecondsbecome numbers, andtrue/falsestrings become booleans. Before, they reached the tool raw. Saved canvas workflows are unchanged.Stagehand
maxStepscoerced to a number) instead of the extract mapping. Saved canvas workflows are unchanged.AWS STS
durationSecondsto an integer, as the canvas already did. Saved canvas workflows are unchanged.Supabase
body,headers,method, andisPublicare unchanged. Saved canvas workflows are unchanged.Tailscale
descriptionandexpirySeconds(both were always dropped before). Unset reusable/ephemeral/preauthorized now get the block defaults, andtrue/falsestrings are converted to booleans.Temporal
workflowTaskFinishEventIdare converted to numbers. A Create Schedule call where the model sendspausedas "false" no longer creates a paused schedule.Textract
['QUERIES']when the model also sent queries.Tinybird
url.TinyFish
goalis still kept.Trigger.dev
taskIdentifier,status,tags,pageSize,data,delay,idempotencyKey,version,period/from/to,page, and so on) to undefined on every tool call.Vercel
blockingas a boolean: the stringtruebecomes true and a missing value becomes false.Review follow-ups
formatandrecursive: false.Testing
params(modelArgs, { operation })without an operation in params, and were confirmed to fail on the pre-fix code.check:mapper-operation,check:explicit-any,check:tool-metadata,check:docs,check:docs-manifest,check:block-successors,check:deployment-config,check:canvas-sentences,check:test-patterns,check:utils,check:comment-hygiene,check:source-conventionsandcheck:integration-cataloglocally. CI runs type-check and the full suite.🤖 Generated with Claude Code