Skip to content

fix(blocks): read the mapper operation from the tool-call context in google, microsoft and atlassian blocks - #10076

Merged
waleedlatif1 merged 9 commits into
stagingfrom
sweep2/m2
Nov 16, 2026
Merged

waleedlatif1 merged 9 commits into
stagingfrom
sweep2/m2

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Moves every block mapper for the Google, Microsoft and Atlassian blocks onto mapperOperation (added in #10070), so the operation is read from the tool-call context. These integrations were validated in earlier sweeps, so this PR covers the mapper fix plus any defects found while tracing it.

  • params.operation is undefined when a block runs as an Agent tool, in Pi or in Human-in-the-loop, so until now these mappers skipped their per-operation renames and coercions on those paths. Each newly live branch keeps the model's own args (via toolCallArg), accepts already-typed values, and never overwrites an arg with undefined.
  • Canvas requests for saved workflows are unchanged, except for the fixes listed below. No ids were renamed or removed.
  • The check:mapper-operation baseline shrinks for every block fixed here, and generated tool metadata and docs are regenerated.

Release notes

Azure DevOps

  • As an Agent tool (or in Pi / Human-in-the-loop), Azure DevOps now applies the block's coercions: bare YYYY-MM-DD dates are expanded to ISO timestamps, string IDs and numbers are converted, and a model top, continuationToken, iterationPath, or format is kept. Get Work Items Batch ids and Add Comment text from the model are forwarded.
  • In the legacy block, when an agent tool call creates or updates a work item with Effort, Remaining Work, or Completed Work set to 0, the 0 is now sent instead of dropped. On the canvas, a reference that resolves to the number 0 is also sent now. Stored string values behave as before.

Bitbucket

  • As an Agent tool (or in Pi / Human-in-the-loop), Bitbucket no longer fails the block mapping, which used to throw "Invalid Bitbucket operation: undefined" and leave the tool with raw params. Values are now trimmed and validated, comma-separated reviewer UUIDs and commit include/exclude lists are split into arrays, Trigger Pipeline defaults the ref type to "branch", and model args such as commit, name, q, refName, and closeSourceBranch are kept.

Confluence

  • As an Agent tool (or in Pi / Human-in-the-loop), Confluence now runs the per-operation mapping. Upload Attachment normalizes the model's file (a JSON string or one-element array becomes a single file), and defaults now apply: List Comments bodyFormat "storage", Add Label prefix "global", Create Blog Post status "current", Delete purge false. Model cursor, spaceKey, propertyId, and property key are kept.

Gmail

  • As an Agent tool (or in Pi / Human-in-the-loop), Gmail now runs the per-operation mapping. Read defaults the folder to INBOX and trims it, move/label message and label IDs are normalized, and List Threads/Drafts labelIds sent as an array are joined into the comma-separated string the tool expects. Before, the array reached the tool, whose .split would throw.

Google AppSheet

  • As an Agent tool (or in Pi / Human-in-the-loop), Find Rows no longer fails on a leftover, invalid Rows JSON value. Add, edit, and delete rows behave as before.

Google Calendar

  • As an Agent tool (or in Pi / Human-in-the-loop), List Events now uses the time zone saved on the tool row (listTimeZone), sent as timeZone. A timeZone the model supplies is now kept too (before, it was dropped) and still applies when nothing is saved. Canvas behavior is unchanged.
  • Create, update, delete, move, quick add, invite, and respond now default sendUpdates to "all" when the row and the model leave it blank, the same as on the canvas.
  • Invite keeps replaceExisting=true when the model sends it as a boolean.

Google Drive

  • As an Agent tool (or in Pi / Human-in-the-loop), Google Drive now uses the file, folder, and destination folder picked on the tool row for the operation being run (get file, download, copy, move, share, export, comments, revisions, and so on), even when the model also supplies fileId, folderId, or destinationFolderId. Before, these picker values were dropped on tool calls. Saved canvas workflows send the same requests as before.
  • Export and Get Content now use the export format chosen on the tool row. A mimeType the model sends to Export or Get Content is kept.
  • Boolean arguments the model sends as true/false (starred on Update, removeFromCurrent on Move, sendNotification on Share, includeRevisions on Get Content/Download, includeDeleted on List Comments) are no longer silently dropped. On the canvas, these fields now also accept a reference that resolves to a real boolean; dropdown values behave exactly as before.
  • The List/Search order-by and shared-drive fields, the List Comments "modified after" field, and the Share expiration/discovery fields set on the tool row are now used.

Google Forms

  • As an Agent tool (or in Pi / Human-in-the-loop), Google Forms now applies the block's input mapping (IDs trimmed, page size converted to a number, publish-setting defaults). Before, the mapping always failed and the tool got the raw arguments.

Google Groups

  • As an Agent tool (or in Pi / Human-in-the-loop), Google Groups now runs the per-operation mapping (maxResults converted to a number, derived-membership flag, settings stringified). The model's name/email on Update Group and email on Add Member are kept.

Google Maps

  • As an Agent tool (or in Pi / Human-in-the-loop), Google Maps now keeps the model's lat/lng, location, place type, and includedTypes, and array-valued destinations, waypoints, placeIds, WiFi access points, and cell towers. Before, all of these were dropped. Validate Address keeps the model's address and Speed Limits keeps its units.

Google Sheets

  • As an Agent tool (or in Pi / Human-in-the-loop), Delete Sheet, Delete Rows, and Copy Sheet now work with model-supplied sheetId/sourceSpreadsheetId. Before, they threw.
  • Batch Update keeps the model's data, which used to be replaced with an empty list. Batch Get/Clear, Create, Read, Write, Update, Append, and Clear accept already-parsed arrays. Append keeps the model's valueInputOption and Read keeps its majorDimension.

Google Slides

  • As an Agent tool (or in Pi / Human-in-the-loop), Write now uses the slide index the model supplies. Before, it was dropped and the call always targeted slide 0.
  • Create Presentation and Copy Presentation now place the file in the folder the model supplies. Before, folderId was dropped.
  • Google Slides now applies the block's per-operation field mapping, keeping the model's IDs (objectId, pageObjectId, objectIds, slideObjectIds, tableObjectId, imageObjectId, imageUrl, findText, text) when the block field is empty. The z-order enum is still taken from the model's operation argument.
  • Add Image (v2) accepts a model-supplied image URL when no file is uploaded.
  • Legacy block (canvas): Add Image now sends the configured image (URL or uploaded file with an https URL) to the API. Before, the image never reached the tool and every Add Image run failed.

Google Vault

  • As an Agent tool (or in Pi / Human-in-the-loop), List Matters now applies the Detail Level and Matter State set on the tool row (sent as view/state; before, they were ignored). Create Export and Create Saved Query now honor the Include Shared Drives switch set on the row, and otherwise send includeSharedDrives=false when the model gives no value.

Jira

  • As an Agent tool (or in Pi / Human-in-the-loop), Jira now maps fields set on the tool row to the tool's params, including Comment Body, Transition Comment/Fields, Worklog Comment, Update Parent Issue, users/projects search and pagination fields, and the update-worklog time. Before, these were ignored on tool calls. Model-supplied values still apply when the row field is blank.
  • Labels, components, fixVersions, and search fields sent as arrays, and deleteSubtasks/notifyUsers sent as booleans, are now handled correctly. Tool calls also apply the block's coercions: comma lists, default issue type "Task", and validation of worklog seconds.
  • Canvas runs: saved string inputs are unchanged. Inputs that resolve to an already-parsed object/array or a boolean now work where they used to throw or be dropped: Jira labels/fields arrays and deleteSubtasks/notifyUsers booleans. A Jira search fields value made only of commas/blanks is now sent as undefined instead of [], which the tool treats the same way.

Jira Service Management

  • As an Agent tool (or in Pi / Human-in-the-loop), Jira Service Management now runs the operation-specific mapping. Row fields such as Comment Body, Organization Name, Participant Account IDs, Decision, Form Answers, the Assets IDs/AQL query/attributes, pagination, and filters are sent under the tool's param names. Model args under the tool's own names (body, name, accountIds, decision, answers, schemaId, objectTypeId, objectId, qlQuery, attributes, start/limit, ...) are kept. Already-parsed JSON objects/arrays and boolean flags from the model are accepted.
  • Canvas runs: requestFieldValues, formAnswers, and formIds that resolve to an already-parsed object/array now work where they used to throw or be dropped. Saved string inputs are unchanged.

Microsoft Entra ID

  • As an Agent tool (or in Pi / Human-in-the-loop), Entra ID (Azure AD) now keeps the model's boolean Mail Enabled / Security Enabled values on Create Group. A true used to be sent as false.
  • Per-operation fields saved on the tool row are now applied (sign-in, audit, app-role, service principal, device, and policy filter/search fields, Membership Scope, the Account Enabled (create) and Visibility (create) dropdowns, Include Manager), and the model's set-password, accountEnabled, and visibility values are kept.

Microsoft Dataverse

  • As an Agent tool (or in Pi / Human-in-the-loop), Dataverse now forwards Search Entities saved on the tool row as the search entities, and applies the Function Parameters and Metadata Select fields saved on the tool row.
  • Get Entity Metadata (Get Table Metadata) no longer sends a record-column Select value left over from a List Records or Get Record operation as the metadata $select. Before, a saved workflow that switched operations with Metadata Select left empty sent record column names as $select to EntityDefinitions.

Microsoft Excel

  • No change for Agent tool calls or canvas runs (only the way the mapper reads the operation changed).

Microsoft Planner

  • As an Agent tool (or in Pi / Human-in-the-loop), update/delete/get-details task operations now keep the model's taskId, and create/update plan keep the model's title. Object checklist, references, categoryDescriptions, and sharedWith values no longer cause an error. Task, bucket, and plan-title fields saved on the tool row (updateTaskId, readTaskId, bucketIdForRead, planTitle) now map to the tool's params.

Microsoft Teams

  • As an Agent tool (or in Pi / Human-in-the-loop), writing to a chat or channel now turns a single attached file (or a JSON string of files) into the file list the tool expects, and chat, team, and channel IDs are trimmed.

Microsoft Word

  • As an Agent tool (or in Pi / Human-in-the-loop), Word now gets the block's coercions: trimming, matchCase as a boolean, numeric pageSize, and folder pickers. Before, the mapper threw and raw params were sent. Append uses the model's content, and create, create-from-template, and list keep the model's folderId.

OneDrive

  • As an Agent tool (or in Pi / Human-in-the-loop), OneDrive (download, delete, move, copy, get item, share link, list, upload, create folder) now keeps the file and folder IDs the model supplies. Before, the mapper erased fileId, folderId, and destinationFolderId, so these calls ran without the target ID. File and folder pickers saved on the tool row are now forwarded too.

Outlook

  • As an Agent tool (or in Pi / Human-in-the-loop), Outlook now applies the block's field mapping, which was previously skipped. Values saved in the tool row's dedicated fields are now forwarded: reply/forward cc/bcc, send/draft importance, message, folder, and destination IDs, calendar ID, event ID, and event fields. Read defaults the folder to INBOX. Reply All never sends a cc.
  • The model's isHidden (Create Folder), isAllDay and isOnlineMeeting (Create Event), and sendResponse (Respond to Event) are now passed along. The string forms true/false are converted to booleans, and saved-row values still win over the model's. Canvas runs are unchanged.

SharePoint

  • As an Agent tool (or in Pi / Human-in-the-loop), Get List Item (v2) now applies the tool row's Item Select Fields and still keeps the model's own selectFields. Create List tool calls (v1 and v2) now apply the row's Column Definitions as the list columns.

Trello

  • As an Agent tool (or in Pi / Human-in-the-loop), Trello now runs the operation the agent picked. Before, every call went through the List Lists logic: calls without a board ID failed that step and reached the tool with unmapped params, and List Cards/Get Actions-style calls that included a board ID had the model's filter dropped. Create Board, Search, Create/Update List, checklist, and Update Card calls now forward the model's name/query/pos/idBoard/labelIds/memberIds/limits as sent.

Review follow-ups

  • Google Slides (legacy v1) Add Image now maps the image source, including images referenced from other blocks.
  • Known limitation: an Agent tool call can't clear a Trello card description by sending an empty string.

Testing

  • Each integration (or batch of blocks) was fixed by one agent and then reviewed by independent adversarial reviewers until it came back clean. Integrations got a vendor-spec/auth lens and a canvas-vs-tool-call/backward-compat lens; batches got the canvas-vs-tool-call lens.
  • Regression tests call each mapper the way the Agent path does, params(modelArgs, { operation }) without an operation in params, and were confirmed to fail on the pre-fix code.
  • Ran the touched test files, biome, check:mapper-operation, check:explicit-any, check:tool-metadata, check:docs, check:docs-manifest, check:block-successors, check:deployment-config, check:canvas-sentences, check:test-patterns, check:utils, check:comment-hygiene, check:source-conventions and check:integration-catalog locally. CI runs type-check and the full suite.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 16, 2026 3:27am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 50 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/google_sheets.ts Resolved
@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The PR appears safe to merge with the documented empty-description limitation.

Summary

Updates Google, Microsoft, and Atlassian block mappers to read the selected operation from tool-call context and preserve supported model arguments.

  • Google Drive tool calls use the file and folder choices for the operation.
  • Google Slides tool calls keep model inputs for the selected operation.
  • Other Google blocks map tool calls with the selected operation.
  • Jira tool calls map saved fields and model arguments to each action.
  • Jira Service Management tool calls map fields for the selected action.
  • Microsoft directory and data blocks map tool calls by operation.
  • Microsoft Planner, Word, and Teams tool calls keep the selected action’s inputs.
  • Microsoft file and mail tool calls apply saved fields and keep model values.
  • Azure DevOps and Bitbucket tool calls map inputs for the selected operation.
  • Confluence tool calls map saved fields and model inputs for each action.
  • Gmail tool calls map message and label inputs for the selected action.
  • Trello tool calls run the action selected by the model.
  • The mapper-check baselines now cover fewer of the fixed blocks.

Reviews (3) · Last reviewed commit: "fix(trello): drop blank card description..." · Reviewed by Greptile

Comment thread apps/sim/blocks/blocks/google_slides.ts Resolved
Comment thread apps/sim/blocks/blocks/trello.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

Comment thread apps/sim/blocks/blocks/trello.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 50 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 50 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 41c840c into staging Nov 16, 2026
31 of 32 checks passed
@waleedlatif1
waleedlatif1 deleted the sweep2/m2 branch November 16, 2026 04:00

This branch was successfully deployed

1 active deployment
Preview — 87b7110f Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant