Repository navigation
fix(blocks): read the mapper operation from the tool-call context in google, microsoft and atlassian blocks - #10076
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
All reported issues were addressed across 50 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[High impact] The PR appears safe to merge with the documented empty-description limitation. SummaryUpdates Google, Microsoft, and Atlassian block mappers to read the selected operation from tool-call context and preserve supported model arguments.
Reviews (3) · Last reviewed commit: "fix(trello): drop blank card description..." · Reviewed by Greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
fc03f8d to
db17594
Compare
…l-call context and validate integrations against vendor specs
…e source and keep empty trello descriptions on tool calls
…eld never erases one
db17594 to
8c0678f
Compare
# Conflicts: # scripts/check-mapper-operation.baseline.json
Summary
Moves every block mapper for the Google, Microsoft and Atlassian blocks onto
mapperOperation(added in #10070), so the operation is read from the tool-call context. These integrations were validated in earlier sweeps, so this PR covers the mapper fix plus any defects found while tracing it.params.operationis undefined when a block runs as an Agent tool, in Pi or in Human-in-the-loop, so until now these mappers skipped their per-operation renames and coercions on those paths. Each newly live branch keeps the model's own args (viatoolCallArg), accepts already-typed values, and never overwrites an arg withundefined.check:mapper-operationbaseline shrinks for every block fixed here, and generated tool metadata and docs are regenerated.Release notes
Azure DevOps
YYYY-MM-DDdates are expanded to ISO timestamps, string IDs and numbers are converted, and a modeltop,continuationToken,iterationPath, orformatis kept. Get Work Items Batchidsand Add Commenttextfrom the model are forwarded.Bitbucket
commit,name,q,refName, andcloseSourceBranchare kept.Confluence
bodyFormat"storage", Add Label prefix "global", Create Blog Post status "current", Deletepurgefalse. Modelcursor,spaceKey,propertyId, and property key are kept.Gmail
labelIdssent as an array are joined into the comma-separated string the tool expects. Before, the array reached the tool, whose.splitwould throw.Google AppSheet
Google Calendar
listTimeZone), sent astimeZone. AtimeZonethe model supplies is now kept too (before, it was dropped) and still applies when nothing is saved. Canvas behavior is unchanged.sendUpdatesto "all" when the row and the model leave it blank, the same as on the canvas.replaceExisting=truewhen the model sends it as a boolean.Google Drive
fileId,folderId, ordestinationFolderId. Before, these picker values were dropped on tool calls. Saved canvas workflows send the same requests as before.mimeTypethe model sends to Export or Get Content is kept.starredon Update,removeFromCurrenton Move,sendNotificationon Share,includeRevisionson Get Content/Download,includeDeletedon List Comments) are no longer silently dropped. On the canvas, these fields now also accept a reference that resolves to a real boolean; dropdown values behave exactly as before.Google Forms
Google Groups
maxResultsconverted to a number, derived-membership flag, settings stringified). The model's name/email on Update Group and email on Add Member are kept.Google Maps
includedTypes, and array-valued destinations, waypoints,placeIds, WiFi access points, and cell towers. Before, all of these were dropped. Validate Address keeps the model's address and Speed Limits keeps its units.Google Sheets
sheetId/sourceSpreadsheetId. Before, they threw.valueInputOptionand Read keeps itsmajorDimension.Google Slides
folderIdwas dropped.objectId,pageObjectId,objectIds,slideObjectIds,tableObjectId,imageObjectId,imageUrl,findText,text) when the block field is empty. The z-order enum is still taken from the model's operation argument.Google Vault
view/state; before, they were ignored). Create Export and Create Saved Query now honor the Include Shared Drives switch set on the row, and otherwise sendincludeSharedDrives=falsewhen the model gives no value.Jira
deleteSubtasks/notifyUserssent as booleans, are now handled correctly. Tool calls also apply the block's coercions: comma lists, default issue type "Task", and validation of worklog seconds.deleteSubtasks/notifyUsersbooleans. A Jira searchfieldsvalue made only of commas/blanks is now sent as undefined instead of[], which the tool treats the same way.Jira Service Management
body,name,accountIds,decision,answers,schemaId,objectTypeId,objectId,qlQuery,attributes,start/limit, ...) are kept. Already-parsed JSON objects/arrays and boolean flags from the model are accepted.requestFieldValues,formAnswers, andformIdsthat resolve to an already-parsed object/array now work where they used to throw or be dropped. Saved string inputs are unchanged.Microsoft Entra ID
trueused to be sent asfalse.accountEnabled, andvisibilityvalues are kept.Microsoft Dataverse
entities, and applies the Function Parameters and Metadata Select fields saved on the tool row.$select. Before, a saved workflow that switched operations with Metadata Select left empty sent record column names as$selectto EntityDefinitions.Microsoft Excel
Microsoft Planner
taskId, and create/update plan keep the model's title. Object checklist, references,categoryDescriptions, andsharedWithvalues no longer cause an error. Task, bucket, and plan-title fields saved on the tool row (updateTaskId,readTaskId,bucketIdForRead,planTitle) now map to the tool's params.Microsoft Teams
Microsoft Word
matchCaseas a boolean, numericpageSize, and folder pickers. Before, the mapper threw and raw params were sent. Append uses the model'scontent, and create, create-from-template, and list keep the model'sfolderId.OneDrive
fileId,folderId, anddestinationFolderId, so these calls ran without the target ID. File and folder pickers saved on the tool row are now forwarded too.Outlook
isHidden(Create Folder),isAllDayandisOnlineMeeting(Create Event), andsendResponse(Respond to Event) are now passed along. The string formstrue/falseare converted to booleans, and saved-row values still win over the model's. Canvas runs are unchanged.SharePoint
selectFields. Create List tool calls (v1 and v2) now apply the row's Column Definitions as the list columns.Trello
filterdropped. Create Board, Search, Create/Update List, checklist, and Update Card calls now forward the model's name/query/pos/idBoard/labelIds/memberIds/limits as sent.Review follow-ups
Testing
params(modelArgs, { operation })without an operation in params, and were confirmed to fail on the pre-fix code.check:mapper-operation,check:explicit-any,check:tool-metadata,check:docs,check:docs-manifest,check:block-successors,check:deployment-config,check:canvas-sentences,check:test-patterns,check:utils,check:comment-hygiene,check:source-conventionsandcheck:integration-cataloglocally. CI runs type-check and the full suite.🤖 Generated with Claude Code