Repository navigation
fix(blocks): read the mapper operation from the tool-call context in internal and a–i blocks - #10077
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[Critical impact] The PR appears safe to merge; no new blocking issues were found. SummaryThe PR moves internal and A–I block mappers to
Reviews (4) · Last reviewed commit: "fix(blocks): send one folder target on F..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 85 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…l-call context and validate integrations against vendor specs
…e args, fix CI type and canonical-id checks Table upsert keeps a tool row's conflictTarget when conflictColumn is unset; affinity parses model rank/winRate through the same numeric validation; instantly treats a whitespace interestValue as empty on tool calls; file reads the model folderPath via its canonical folderRef; dub's mapper context is optional; buffer test typing; shrink the test-types baseline for ashby.
…share emails, and boolean enabled filters
0cb7960 to
18fd17e
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 86 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…ype when disabling sharing
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
On a tool call the mapper result is spread over the merged row and model params, so a model folderPaths survived beside the row's folderPath (or the model's own folderPath) and the file contract refused the pair. Clear whichever folder arg the resolved target did not set.
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
# Conflicts: # scripts/check-mapper-operation.baseline.json
Summary
Moves every block mapper for the internal blocks and integrations A–I onto
mapperOperation(added in #10070), so the operation is read from the tool-call context. These integrations were validated in earlier sweeps, so this PR covers the mapper fix plus any defects found while tracing it.params.operationis undefined when a block runs as an Agent tool, in Pi or in Human-in-the-loop, so until now these mappers skipped their per-operation renames and coercions on those paths. Each newly live branch keeps the model's own args (viatoolCallArg), accepts already-typed values, and never overwrites an arg withundefined.check:mapper-operationbaseline shrinks for every block fixed here, and generated tool metadata and docs are regenerated.Release notes
Deployments
File
folderPaththe model supplies.isActive/authType/allowedEmailsinstead of always making the link public.fileName/fileIdwhen the row has no picked file, instead of throwing in the mapper.Knowledge
enabledinto a boolean, so a model-sent "false" really disables the chunk.LaTeX
name.Logs
idorexecutionId. Before, they always ran the query mapping and ignored those fields.Memory
conversationId,role, andcontentdirectly. Results are unchanged.Table
[{"field":"wins","direction":"desc"}]is now kept instead of being dropped.Affinity
limit, rank, win rate, period days) are converted to numbers.AgentMail
permanentorreplyAllflag is kept, and the model'stoonreply_messageis not cleared.AgentPhone
Algolia
createIfNotExists,forwardToReplicas,getRankingInfo) are converted to real booleans. The model's own filters, requests, and copy/move choice for Copy/Move Index are kept when the tool row leaves those fields empty.Amplitude
Apollo
organizationsvalue now becomesdomains.Ashby
Bright Data
query,datasetId, andurlsare still used when the block field is empty.Buffer
addToQueueand the default scheduling type asautomatic, instead of dropping the required mode. Edit Post's "clear text" option now works on tool calls.CB Insights
orgIdsandurls.Checkr
tags,geoId,programId,node, andworkLocationsare kept when those block fields are empty.Circleback
Clerk
Coda
sortBy, publish mode, analytics options, booleans, and so on). Before, the block blanked them on every tool call. List rows uses the saved row filter and sort, and workspace filters reach list operations.tableTypesfilter the model sends as an array (for example['table']). Before, the filter was dropped and every table type came back, views included. Saved canvas workflows are unchanged.Context.dev
Crunchbase
DocuSign
Downdetector
NaN, so you couldn't get past the first page. Canvas runs are unchanged.Dub
url,domain,key,title,description,externalId,tagIds,tenantId,folderId,linkId,search,showArchived,page, andpageSizeblanked, so Create/Upsert Link lost its destination URL, Get/Update/Delete Link lost itslinkId, the analytics, events, and count filters were dropped, and Get QR Code lost its URL.trackConversionboolean. Before, it was always dropped. Canvas workflows are unchanged.ElevenLabs
style,speed, anduseSpeakerBoost(they used to be dropped), and keeps itsstability/similarityBoost.Email Bison
status,leadId, andtagIdsfor List Replies, itstagIdsfor List Leads and Attach Tags to Leads, and itsnamefor Create Tag, Create Campaign, and Update Campaign. They used to be dropped.Enrich
companyIdsno longer fails with "Invalid JSON input" and skips the block's parameter mapping. All Enrich rename branches (LinkedIn profile/email/phone, company lookup/search, similar companies, post details, logo, jobs) now keep the model's value. Canvas behavior is unchanged, except that a Search Jobs canvas run no longer throws on a stale non-JSONcompanyIdsvalue.Enrichment
enrichmentIdis kept instead of being overwritten with undefined. Canvas runs are unchanged.Exa
Firecrawl
Fireflies
Flint
Gong
flowIdis kept. Canvas runs of saved workflows are unchanged.Grain
Greenhouse
Harmonic
query,personId,savedSearchId,personUrns, size/cursor, and so on). Before, every Harmonic tool call reached the tool with those params cleared. Canvas runs are unchanged.Help Scout
status,type, andsortField(list/create/update conversation status, reply/note status, list customers sort). Before, these were always cleared. Canvas runs are unchanged.Hex
Instagram
mediaId,caption,igUserId,limit,commentId,message, and so on) was cleared, so these calls failed or ran without their inputs. Publish Carousel now sends the model'smediafiles, and Get Account/Media Insights now send the model'smetrics. Canvas behavior is unchanged.Instantly
interest_value, so the call no longer always fails with "Interest Value is required". A null value still resets the lead to Lead.first_name,last_name,company_name,job_title,campaign,list_id,campaign_id,custom_variables,lt_interest_status, theskip_if_*andverify_*flags,ids,limit,status,search,starting_after,name,campaign_schedule,email_list,daily_limit, tracking flags,eaccount,reply_to_uuid,lead_email, the cc/bcc lists,owned_by, and more. Before, create/patch lead, list filters, delete-leads scope, campaign create/patch, and list-emails filters sent these fields empty.Review follow-ups
Testing
params(modelArgs, { operation })without an operation in params, and were confirmed to fail on the pre-fix code.check:mapper-operation,check:explicit-any,check:tool-metadata,check:docs,check:docs-manifest,check:block-successors,check:deployment-config,check:canvas-sentences,check:test-patterns,check:utils,check:comment-hygiene,check:source-conventionsandcheck:integration-cataloglocally. CI runs type-check and the full suite.🤖 Generated with Claude Code