Skip to content

fix(blocks): read the mapper operation from the tool-call context in internal and a–i blocks - #10077

Merged
waleedlatif1 merged 11 commits into
stagingfrom
sweep2/m3
Nov 16, 2026
Merged

waleedlatif1 merged 11 commits into
stagingfrom
sweep2/m3

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Moves every block mapper for the internal blocks and integrations A–I onto mapperOperation (added in #10070), so the operation is read from the tool-call context. These integrations were validated in earlier sweeps, so this PR covers the mapper fix plus any defects found while tracing it.

  • params.operation is undefined when a block runs as an Agent tool, in Pi or in Human-in-the-loop, so until now these mappers skipped their per-operation renames and coercions on those paths. Each newly live branch keeps the model's own args (via toolCallArg), accepts already-typed values, and never overwrites an arg with undefined.
  • Canvas requests for saved workflows are unchanged, except for the fixes listed below. No ids were renamed or removed.
  • The check:mapper-operation baseline shrinks for every block fixed here, and generated tool metadata and docs are regenerated.

Release notes

Deployments

  • As an Agent tool (or in Pi / Human-in-the-loop), Deploy now keeps the version name and description the model supplies. Before, they were dropped.
  • Promote and Get Version Details now check that the version is a whole number of 1 or more before the call is made.

File

  • As an Agent tool (or in Pi / Human-in-the-loop), Get Content, Compress, Append, Edit, Decompress, Manage Sharing, and the folder operations now use the file or folder picked in the tool row, and the row's other fields. Before, the block mapper threw and the tool got the raw, unmapped row values.
  • Write, Move, Append, and Edit now keep the folderPath the model supplies.
  • Manage Sharing now honors the model's isActive/authType/allowedEmails instead of always making the link public.
  • File (Legacy v3/v4) Append, Get, and Read now accept the model's fileName/fileId when the row has no picked file, instead of throwing in the mapper.
  • Move Folder now works when the tool row pins a destination parent and the model names the folder to move. Before, the move failed because no destination path reached the tool.
  • File v5 Create Folder now creates the folder under the Parent Folder set in the tool row. The folder takes the last segment of the path the model supplied. Before, the model's full path was used as-is.

Knowledge

  • As an Agent tool (or in Pi / Human-in-the-loop), Update Chunk now turns a string "true"/"false" for enabled into a boolean, so a model-sent "false" really disables the chunk.
  • List Chunks now applies the tool row's Search and Status Filter fields. A Status Filter left at the default "All" does not override a status filter the model asked for.
  • Upsert Document now sends the Document ID set on the tool row, and trims it.
  • Create/Upsert Document now parse Document Tags supplied as a JSON string. Tool calls that operate on a document, chunk, or connector now trim those IDs.

LaTeX

  • As an Agent tool (or in Pi / Human-in-the-loop), Search Packages now sends the search query typed into the tool row. Before, it was dropped, because every tool call went through the compile mapping. Get Package now uses the package name from the tool row and trims it, falling back to the model's name.

Logs

  • As an Agent tool (or in Pi / Human-in-the-loop), Logs (legacy) Get Log by ID and Get Execution Details now send the Log ID or Execution ID typed into the tool row, falling back to the model's id or executionId. Before, they always ran the query mapping and ignored those fields.

Memory

  • As an Agent tool (or in Pi / Human-in-the-loop), Memory no longer logs a "Memory Block Error: Operation is required" error on every call. The block mapper now runs and sends conversationId, role, and content directly. Results are unchanged.

Table

  • As an Agent tool (or in Pi / Human-in-the-loop), Table (v1, legacy) now applies the tool row's configured builder filter and sort (and bulk builder filter), Columns to Return, and limit/offset coercion. Before, these were ignored on tool calls. If the row's builder has no rules, the model's filter/sort is used.
  • Table now sends the model's filter and order to the tool. Before, Query Rows ran with no filter or order, and Update Rows / Delete Rows by Filter received no filter. A model-supplied order spec like [{"field":"wins","direction":"desc"}] is now kept instead of being dropped.

Affinity

  • As an Agent tool (or in Pi / Human-in-the-loop), the legacy Affinity block now works. Before, the mapper dropped every argument except the API key. Model-supplied IDs, filters, names, and other tool params are now kept, and tool-row fields such as Note Entity Type are mapped to the tool params. Limit and numeric strings the model sends (limit, rank, win rate, period days) are converted to numbers.

AgentMail

  • As an Agent tool (or in Pi / Human-in-the-loop), the legacy AgentMail block now applies the tool-row fields: inbox ID override, reply/forward/update message ID, label lists, draft In-Reply-To, and Limit coerced to a number. A model's boolean permanent or replyAll flag is kept, and the model's to on reply_message is not cleared.
  • A saved "Permanent Delete = No" no longer permanently deletes the thread; it moves it to trash. A saved "Reply All = No" no longer replies to all recipients; it replies only to the sender. The tool row stored the string "false", which was treated as true. Canvas runs are unchanged.

AgentPhone

  • As an Agent tool (or in Pi / Human-in-the-loop), AgentPhone now applies the tool-row fields: agent, number, message body, contact fields, call filters, and search. Limits, offsets, and days/months (including numeric strings from the model) are coerced to numbers, and metadata JSON is parsed.

Algolia

  • As an Agent tool (or in Pi / Human-in-the-loop), the legacy Algolia block now applies the tool-row Delete Filters, Get Records Requests, and copy/move operation fields. String booleans (createIfNotExists, forwardToReplicas, getRankingInfo) are converted to real booleans. The model's own filters, requests, and copy/move choice for Copy/Move Index are kept when the tool row leaves those fields empty.

Amplitude

  • As an Agent tool (or in Pi / Human-in-the-loop), Amplitude now maps the operation-specific tool-row fields (for example Segmentation Event Type, Funnel Events, and Retention Start Event) to the tool's params.

Apollo

  • As an Agent tool (or in Pi / Human-in-the-loop), Apollo and Apollo v2 now use the fields filled in on the tool row, as the canvas already did. Before, these row fields were silently dropped on tool calls. Account bulk update: Uniform Name, Owner ID, and Account Stage ID now reach the call, and a Contacts or Accounts JSON array is split into IDs and attributes. Contact create: Run Deduplication now reaches the call. Account and opportunity create and update: the name field now reaches the call. Sequence add: Acting User ID, label names, and Initial Status now reach the call. Task create: Task Notes now reach the call. Organization bulk enrich: a legacy organizations value now becomes domains.
  • On a sequence add tool call, a status the model supplies now wins over the tool row's Initial Status dropdown, which fills in "active" automatically. Canvas behavior is unchanged.

Ashby

  • As an Agent tool (or in Pi / Human-in-the-loop), Ashby (legacy and v2) now forwards block-only fields saved on the tool row under the tool's param names: Create Application's candidate and created-at fields, Create/Update Candidate's location and created-at override, Create Note's created-at, List Offers' application filter, List Jobs' "include unpublished posting IDs" switch (now sent under the key List Jobs expects), and Results per page as the search limit.
  • Set Custom Field Value now decodes the field value the same way the canvas does: null clears the field, numbers and JSON are decoded, and plain text stays as-is.
  • Upload Resume and Upload Candidate File now normalize the file input to a single file, as the canvas does.

Bright Data

  • As an Agent tool (or in Pi / Human-in-the-loop), Bright Data now applies the block's saved fields for the selected operation: Sync Scrape dataset, URLs, and format; Discover query and content format; Scrape Dataset and Download Snapshot formats. Before, these were silently skipped. The model's own query, datasetId, and urls are still used when the block field is empty.

Buffer

  • As an Agent tool (or in Pi / Human-in-the-loop), Create Post now sends the default share mode as addToQueue and the default scheduling type as automatic, instead of dropping the required mode. Edit Post's "clear text" option now works on tool calls.

CB Insights

  • As an Agent tool (or in Pi / Human-in-the-loop), CB Insights (legacy and v2 blocks) no longer erases every argument the model supplies (organization IDs, message, filters, limit, page token). Before, everything except the client credentials was cleared, so the call failed or ran unfiltered. Search Firmographics also keeps the model's orgIds and urls.

Checkr

  • As an Agent tool (or in Pi / Human-in-the-loop), Checkr (legacy and v2 blocks) now applies the block's operation-specific fields: report tags on Create Invitation and Create Report, the geo and program filters on List Candidates, the node and work locations on Update Continuous Check, the report adjudication on Update Report, and the subscription status on List Subscriptions. The model's own tags, geoId, programId, node, and workLocations are kept when those block fields are empty.

Circleback

  • As an Agent tool (or in Pi / Human-in-the-loop), List action items and Search meetings now apply the status, assignee, and meeting-ID filters saved on the tool row.

Clerk

  • As an Agent tool (or in Pi / Human-in-the-loop), Clerk now applies the saved per-operation fields: list filters, organization name, and invitation and allowlist notify. Metadata and actor values sent as JSON strings are now parsed into objects.

Coda

  • As an Agent tool (or in Pi / Human-in-the-loop), Coda now keeps the arguments the model sends (query, title, name, content, sortBy, publish mode, analytics options, booleans, and so on). Before, the block blanked them on every tool call. List rows uses the saved row filter and sort, and workspace filters reach list operations.
  • List Tables now honors a tableTypes filter the model sends as an array (for example ['table']). Before, the filter was dropped and every table type came back, views included. Saved canvas workflows are unchanged.

Context.dev

  • As an Agent tool (or in Pi / Human-in-the-loop), Context.dev now coerces numeric options, parses an extraction schema sent as a JSON string, and applies the saved Extract max-pages and SIC type fields.

Crunchbase

  • As an Agent tool (or in Pi / Human-in-the-loop), Crunchbase now sends the model's query, entity ID, field IDs, collection, limit, and cursors. Before, every argument was blanked and calls failed or returned unfiltered results.

DocuSign

  • As an Agent tool (or in Pi / Human-in-the-loop), Send Envelope and Create from Template now use the Status set on the tool row (Send Immediately or Save as Draft) when the model gives no status. Before, the row setting was ignored and DocuSign's default "sent" applied. A status the model provides still takes precedence.

Downdetector

  • As an Agent tool (or in Pi / Human-in-the-loop), Get Site Companies now forwards the model's page token. Before, it was turned into NaN, so you couldn't get past the first page. Canvas runs are unchanged.

Dub

  • As an Agent tool (or in Pi / Human-in-the-loop), Dub (Dub, Dub legacy, and Dub v3) now keeps the arguments the model passes. Before, every tool call had url, domain, key, title, description, externalId, tagIds, tenantId, folderId, linkId, search, showArchived, page, and pageSize blanked, so Create/Upsert Link lost its destination URL, Get/Update/Delete Link lost its linkId, the analytics, events, and count filters were dropped, and Get QR Code lost its URL.
  • Create/Upsert/Update Link now forward the model's trackConversion boolean. Before, it was always dropped. Canvas workflows are unchanged.

ElevenLabs

  • As an Agent tool (or in Pi / Human-in-the-loop), Edit Voice Settings now forwards the model's style, speed, and useSpeakerBoost (they used to be dropped), and keeps its stability/similarityBoost.

Email Bison

  • As an Agent tool (or in Pi / Human-in-the-loop), Email Bison now forwards the model's status, leadId, and tagIds for List Replies, its tagIds for List Leads and Attach Tags to Leads, and its name for Create Tag, Create Campaign, and Update Campaign. They used to be dropped.

Enrich

  • As an Agent tool (or in Pi / Human-in-the-loop), Search Jobs with a comma-separated companyIds no longer fails with "Invalid JSON input" and skips the block's parameter mapping. All Enrich rename branches (LinkedIn profile/email/phone, company lookup/search, similar companies, post details, logo, jobs) now keep the model's value. Canvas behavior is unchanged, except that a Search Jobs canvas run no longer throws on a stale non-JSON companyIds value.

Enrichment

  • As an Agent tool (or in Pi / Human-in-the-loop), Enrichment now runs the selected enrichment with the model's inputs. Before, the enrichment ID and inputs were wiped, so every call failed. If the tool row carries no operation, the model's enrichmentId is kept instead of being overwritten with undefined. Canvas runs are unchanged.

Exa

  • As an Agent tool (or in Pi / Human-in-the-loop), a saved legacy Exa Research row now maps the stored research model to the Agent effort level (Fast to low, Standard to medium, Pro to high), as the canvas does.

Firecrawl

  • As an Agent tool (or in Pi / Human-in-the-loop), Firecrawl now applies the block's coercions: numeric fields are parsed, URL lists and formats are normalized to arrays, and Parse gets a single document even when the model passes a list.

Fireflies

  • As an Agent tool (or in Pi / Human-in-the-loop), Fireflies (v2) Upload Audio now uploads a picked file by its https URL, and accepts a model-supplied audio URL when no file is picked instead of failing.
  • Create Bite keeps the model's bite name and summary and accepts a start time of 0. Numeric and trimmed fields are now coerced on tool calls too.
  • Canvas fix: a Create Bite start or end time that resolves to the number 0 no longer throws "Start time and end time are required."

Flint

  • No user-visible change. Agent tool calls now take the selected operation's branch.

Gong

  • As an Agent tool (or in Pi / Human-in-the-loop), Gong now applies the block's operation-specific field mapping, which used to run only on the canvas. For Unassign Flow Prospects, the model's flowId is kept. Canvas runs of saved workflows are unchanged.

Grain

  • As an Agent tool (or in Pi / Human-in-the-loop), Grain now applies the block's operation-specific field mapping, which used to run only on the canvas. For Grain v2 webhooks, the model's include options and list filters are kept. Canvas runs of saved workflows are unchanged.

Greenhouse

  • As an Agent tool (or in Pi / Human-in-the-loop), the legacy Greenhouse block now applies the block's operation-specific field mapping, which used to run only on the canvas. Canvas runs of saved workflows are unchanged.

Harmonic

  • As an Agent tool (or in Pi / Human-in-the-loop), Harmonic now forwards the model's arguments (query, personId, savedSearchId, personUrns, size/cursor, and so on). Before, every Harmonic tool call reached the tool with those params cleared. Canvas runs are unchanged.

Help Scout

  • As an Agent tool (or in Pi / Human-in-the-loop), Help Scout now keeps the model's status, type, and sortField (list/create/update conversation status, reply/note status, list customers sort). Before, these were always cleared. Canvas runs are unchanged.

Hex

  • As an Agent tool (or in Pi / Human-in-the-loop), Hex now applies the fields saved on the tool row: Group ID (get/update/delete group), collection name/description, group name and member add/remove lists, project status, and the run status / queried-tables cursor / groups user filters. Before, these were dropped, so Get Group with a stored Group ID failed.
  • Hex list tools now drop a sort field the endpoint does not accept, the same as on the canvas.

Instagram

  • As an Agent tool (or in Pi / Human-in-the-loop), Instagram now forwards the model's arguments. Before, every operation-specific arg (mediaId, caption, igUserId, limit, commentId, message, and so on) was cleared, so these calls failed or ran without their inputs. Publish Carousel now sends the model's media files, and Get Account/Media Insights now send the model's metrics. Canvas behavior is unchanged.

Instantly

  • As an Agent tool (or in Pi / Human-in-the-loop), Instantly and Instantly v2 Update Lead Interest Status now sends the model's interest_value, so the call no longer always fails with "Interest Value is required". A null value still resets the lead to Lead.
  • Instantly now keeps the model's arguments that use the tool's param names instead of dropping them: first_name, last_name, company_name, job_title, campaign, list_id, campaign_id, custom_variables, lt_interest_status, the skip_if_* and verify_* flags, ids, limit, status, search, starting_after, name, campaign_schedule, email_list, daily_limit, tracking flags, eaccount, reply_to_uuid, lead_email, the cc/bcc lists, owned_by, and more. Before, create/patch lead, list filters, delete-leads scope, campaign create/patch, and list-emails filters sent these fields empty.
  • Reply To Email now sends the model's reply body instead of an empty body.
  • Canvas (non-agent) runs of saved workflows are unchanged.

Review follow-ups

  • Table v2: a Limit that resolves to the number 0 now fails with a 400 instead of acting on every matching row.
  • File v5 Append/Edit used as an Agent tool sends a single folder target, so a pinned folder plus the model's folders no longer fails.
  • Table upsert as an Agent tool keeps the model's conflict target when the row leaves it blank.

Testing

  • Each integration (or batch of blocks) was fixed by one agent and then reviewed by independent adversarial reviewers until it came back clean. Integrations got a vendor-spec/auth lens and a canvas-vs-tool-call/backward-compat lens; batches got the canvas-vs-tool-call lens.
  • Regression tests call each mapper the way the Agent path does, params(modelArgs, { operation }) without an operation in params, and were confirmed to fail on the pre-fix code.
  • Ran the touched test files, biome, check:mapper-operation, check:explicit-any, check:tool-metadata, check:docs, check:docs-manifest, check:block-successors, check:deployment-config, check:canvas-sentences, check:test-patterns, check:utils, check:comment-hygiene, check:source-conventions and check:integration-catalog locally. CI runs type-check and the full suite.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 16, 2026 3:28am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Critical impact] The PR appears safe to merge; no new blocking issues were found.

Summary

The PR moves internal and A–I block mappers to mapperOperation so tool calls use the selected operation and keep model arguments.

  • A–C integration calls now use the selected operation and keep their inputs.
  • B–D integration calls now apply their saved fields and keep model inputs.
  • D–E integration calls now keep model arguments and apply saved row settings.
  • E–I integration calls now map saved fields and preserve model inputs.
  • File calls now use the selected file, folder, and sharing settings.
  • Knowledge calls now keep document, chunk, connector, and filter inputs.
  • Internal tool calls now use their selected operation and supplied inputs.
  • Table calls now pass their filters, sort order, and limits to row tools.
  • Mapper and type-check baselines now reflect the updated block mappings.

Reviews (4) · Last reviewed commit: "fix(blocks): send one folder target on F..." · Reviewed by Greptile

Comment thread apps/sim/blocks/blocks/table_v2.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 85 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/brightdata.ts Resolved
Comment thread apps/sim/blocks/blocks/crunchbase.ts Resolved
Comment thread apps/sim/blocks/blocks/file.ts Resolved
Comment thread apps/sim/blocks/blocks/instantly.ts Resolved
Comment thread apps/sim/blocks/blocks/coda.ts Resolved
Comment thread apps/sim/blocks/blocks/instagram.ts Resolved
Comment thread apps/sim/blocks/blocks/file.ts Resolved
Comment thread apps/sim/blocks/blocks/file.ts Resolved
Comment thread apps/sim/blocks/blocks/knowledge.ts Resolved
Comment thread apps/sim/blocks/blocks/table.ts Resolved
…l-call context and validate integrations against vendor specs
…e args, fix CI type and canonical-id checks

Table upsert keeps a tool row's conflictTarget when conflictColumn is unset; affinity parses model rank/winRate through the same numeric validation; instantly treats a whitespace interestValue as empty on tool calls; file reads the model folderPath via its canonical folderRef; dub's mapper context is optional; buffer test typing; shrink the test-types baseline for ashby.
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 86 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/table_v2.ts Resolved
Comment thread apps/sim/blocks/blocks/file.ts Resolved
Comment thread apps/sim/blocks/blocks/table_v2.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 86 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

On a tool call the mapper result is spread over the merged row and model params, so a model
folderPaths survived beside the row's folderPath (or the model's own folderPath) and the file
contract refused the pair. Clear whichever folder arg the resolved target did not set.
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 86 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit a86f4c2 into staging Nov 16, 2026
30 of 31 checks passed
@waleedlatif1
waleedlatif1 deleted the sweep2/m3 branch November 16, 2026 04:00

This branch was successfully deployed

1 active deployment
Preview — 5d53a262 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant