Repository navigation
fix(integrations): close gaps found in the final sweep audit - #10081
Merged
Merged
Conversation
- resend: a tool row's pinned audience is no longer retargeted by the model's segmentId; mappers now receive the row's pinned param ids as context.pinnedParams - google forms: a missing title, eventType, topicName or watchId stays missing instead of becoming the text "undefined" - tool-row hidden params: a not-clause on a string option is decided as text, so SharePoint V2 Get List drops item filters a row hides once Include Columns is Yes - attio list_records: accept a filter/sorts the json input already parsed - hubspot create_list, intercom, kalshi: the operation's own field (pinned on a tool row) wins over a model arg or a stale canvas value under the tool param name - rippling: Yes/No flags left on No send a boolean false; setting API name and data type apply only to custom-setting writes
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Critical impact] The changes reviewed appear safe to merge. SummaryFixes integration input mapping so saved tool-row values win over model arguments, missing required values stay missing, and parsed JSON remains usable.
Reviews (2) · Last reviewed commit: "fix(rippling): lead custom object field ..." · Reviewed by Greptile |
Is Unique and Enable History follow the dropdown-default pattern: create defaults to No, an update or an agent tool row leads with No change and sends nothing. Saved workflows that store 'true' or 'false' keep sending that boolean.
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the confirmed gaps from the final audit of the merged integration sweep. Each fix has a regression test that fails when the fix is reverted.
segmentIdcan no longer change who the broadcast goes to. Mappers now getcontext.pinnedParams, the ids of the values the tool row stores.buildBlockToolParamsTransformfills it for Agent and Pi tool rows and for Human-in-the-loop v2 notification tools. The canvas has no context, so canvas runs are unchanged.title,eventType,topicNameorwatchId, the value now stays undefined, so the required-param check rejects the call. Before, it became the text"undefined"and the call went through.isClauseFalseused to retry with the typed reading ('true'→true). That makes anotclause on a string option always pass. Clauses whose options are all strings now compare the stored value as text. With this, SharePoint V2 Get List drops the Filter, Top and Select Fields a row hides when Include Columns is Yes. Before, every call was rejected. If the stored value can't be decided, it is still kept.filter/sortsthat the block's json input already parsed. Before, any filter or sort threwInvalid JSON.name.false, not the text"false". These are All Or Nothing, Is Unique, Enable History, Include Object IDs and Include Total Rows. The setting API name and data type now apply only to create/update custom setting. On Update Custom Object Field, Is Unique and Enable History now start on a "No change" option (Create still defaults to No), so an update no longer resends them. Saved workflows that store Yes or No keep sending that value.Release notes
"false"as text for All Or Nothing, Is Unique, Enable History, Include Object IDs and Include Total Rows. Custom app API names and custom object field data types could be overwritten by values left over from a custom-setting operation."undefined"instead of being rejected.Test plan
bun run test providers/utils.test.ts blocks/blocks/{google_forms,hubspot,intercom,kalshi,rippling,resend}.test.ts tools/attio/json-inputs.test.ts🤖 Generated with Claude Code