Skip to content

fix(integrations): close gaps found in the final sweep audit - #10081

Merged
waleedlatif1 merged 2 commits into
stagingfrom
sweep3/audit-followups
Nov 16, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
sweep3/audit-followups

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Closes the confirmed gaps from the final audit of the merged integration sweep. Each fix has a regression test that fails when the fix is reverted.

  • Resend, Create Broadcast: if a tool row pins Audience ID, the model's segmentId can no longer change who the broadcast goes to. Mappers now get context.pinnedParams, the ids of the values the tool row stores. buildBlockToolParamsTransform fills it for Agent and Pi tool rows and for Human-in-the-loop v2 notification tools. The canvas has no context, so canvas runs are unchanged.
  • Google Forms: if the model leaves out title, eventType, topicName or watchId, the value now stays undefined, so the required-param check rejects the call. Before, it became the text "undefined" and the call went through.
  • Tool-row hidden params: isClauseFalse used to retry with the typed reading ('true' → true). That makes a not clause on a string option always pass. Clauses whose options are all strings now compare the stored value as text. With this, SharePoint V2 Get List drops the Filter, Top and Select Fields a row hides when Include Columns is Yes. Before, every call was rejected. If the stored value can't be decided, it is still kept.
  • Attio, List Records: accepts a filter/sorts that the block's json input already parsed. Before, any filter or sort threw Invalid JSON.
  • HubSpot, Create List: List Name pinned on the tool row now wins over the model's name.
  • Intercom: a block field mapped to a tool param (assignee, company, note/close/assign body, tag contact/company/name/id, event user/email/contact/metadata, message type, company name) now wins over the model's argument under the same tool param name. The model's value still fills the param when the field is empty.
  • Kalshi: the operation's own field now wins over a value under the tool's param name. On the canvas, that value is a stale advanced field from another operation. On a tool call, the row's field is pinned. The model's value fills the param only on a tool call when the field is empty.
  • Rippling: Yes/No fields whose id matches the tool's param name now send a boolean false, not the text "false". These are All Or Nothing, Is Unique, Enable History, Include Object IDs and Include Total Rows. The setting API name and data type now apply only to create/update custom setting. On Update Custom Object Field, Is Unique and Enable History now start on a "No change" option (Create still defaults to No), so an update no longer resends them. Saved workflows that store Yes or No keep sending that value.

Release notes

  • Fixed: Kalshi Get Order, Cancel Order and Amend Order used a stale advanced Order ID from Get Fills, so they could act on the wrong order. Amend Order used a stale Client Order ID from Create Order, and Get Orders used a stale Status filter from Get Markets or Get Events.
  • Fixed: Attio List Records failed whenever a Filter or Sorts value was set.
  • Fixed: SharePoint Get List agent tools failed on every call after Include Columns was switched to Yes on a row that had item filters.
  • Fixed: Rippling sent "false" as text for All Or Nothing, Is Unique, Enable History, Include Object IDs and Include Total Rows. Custom app API names and custom object field data types could be overwritten by values left over from a custom-setting operation.
  • Changed: Rippling Update Custom Object Field's Is Unique and Enable History now offer "No change" and default to it on new updates.
  • Fixed: agent tool calls could override values pinned on the tool row: Resend audience, HubSpot list name, Intercom fields, and Kalshi order/ticker/status fields.
  • Fixed: Google Forms agent tool calls missing a title or watch ID created or targeted "undefined" instead of being rejected.

Test plan

  • bun run test providers/utils.test.ts blocks/blocks/{google_forms,hubspot,intercom,kalshi,rippling,resend}.test.ts tools/attio/json-inputs.test.ts
  • Existing fix(agent): drop tool-row values left from a previous operation #10080 hidden-param tests, tool-input editor, Pi sim-tools and HITL notification tests pass
  • Each new regression test fails with its fix reverted

🤖 Generated with Claude Code

- resend: a tool row's pinned audience is no longer retargeted by the model's segmentId;
  mappers now receive the row's pinned param ids as context.pinnedParams
- google forms: a missing title, eventType, topicName or watchId stays missing instead of
  becoming the text "undefined"
- tool-row hidden params: a not-clause on a string option is decided as text, so SharePoint
  V2 Get List drops item filters a row hides once Include Columns is Yes
- attio list_records: accept a filter/sorts the json input already parsed
- hubspot create_list, intercom, kalshi: the operation's own field (pinned on a tool row)
  wins over a model arg or a stale canvas value under the tool param name
- rippling: Yes/No flags left on No send a boolean false; setting API name and data type
  apply only to custom-setting writes
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 16, 2026 5:37am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 19 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Critical impact] The changes reviewed appear safe to merge.

Summary

Fixes integration input mapping so saved tool-row values win over model arguments, missing required values stay missing, and parsed JSON remains usable.

  • Saved tool-row values stay in control when models supply competing arguments.
  • Kalshi calls use the fields for the selected operation.
  • SharePoint list filters disappear when Include Columns is Yes.
  • Missing Google Forms values stay missing for required checks.
  • Attio List Records accepts parsed filters and sorts.
  • Rippling sends boolean settings and limits custom-setting fields to their operations.

Reviews (2) · Last reviewed commit: "fix(rippling): lead custom object field ..." · Reviewed by Greptile

Is Unique and Enable History follow the dropdown-default pattern: create defaults to No,
an update or an agent tool row leads with No change and sends nothing. Saved workflows
that store 'true' or 'false' keep sending that boolean.
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 19 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 2094e21 into staging Nov 16, 2026
147 of 150 checks passed
@waleedlatif1
waleedlatif1 deleted the sweep3/audit-followups branch November 16, 2026 05:52

This branch was previously deployed

1 inactive deployment
Preview — 043a7f5f Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant