Repository navigation
fix(confluence): index text from Caelor Optics HTML macros - #10093
Conversation
The rendered view body carries a Connect app macro only as an iframe bootstrap script, so pages built from an Optics HTML macro synced with no extractable text. Read the macro's authored HTML from the storage body: visible text with scripts and styles dropped, plus the object-literal data its inline scripts declare.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[Medium impact] The PR appears safe to merge; no new blocking issue was found. SummaryAdds searchable text from Caelor Optics HTML macros without executing their scripts.
All supplied previous threads were unnumbered, so none require entries in
|
…ipt data, retry on a missing storage body
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
caelor-optics-entry,macro=html) synced as "Document contains no extractable text": the renderedviewbody holds the macro only as an iframe bootstrap script, which we strip, and the author's HTML lives in the macro'scontentByModeparameter in the storage bodyscript/styledropped, pluskey: valuerecords from object literals in inline scripts (pages that render their content from a JS data object show only a mount point otherwise).data:payloads and ternaries/caselabels are excludedexport_viewrejected: Connect macros only render there if the app declares an export render modeType of Change
Testing
connectors/confluence/confluence.test.tsat the fetch boundary; the behavior cases failed before the fix, and each half of the storage-fetch trigger was reverted to watch its guard go redconnectors/confluence/(143) andlib/knowledge/connectors(487) vitest suites passcheck:file-names,check:comment-hygiene,check:explicit-any,check:utils,check:organization-egress; full type-check andcheck:auditsleft to CIChecklist
test-auditauthoring gate)🤖 Generated with Claude Code