Repository navigation
fix(slack): keep refused file reads from suggesting a reconnect and find the download URL for trigger files - #10095
Merged
Conversation
…ind the download URL for trigger files
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] This PR appears safe to merge; no blocking issues remain. SummaryThis PR improves Slack file downloads and explains refused reads without suggesting an unnecessary reconnect.
Reviews (2) · Last reviewed commit: "fix(slack): keep a throttled file downlo..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from a final review of the Slack file read/download changes in this release:
files.infohad just accepted the same token, so reconnecting changes nothing. Those reads now say Slack did not serve the file's contents and keep the preview. Other provider reasons pass through unchanged, and areconnecterror that is not an HTTP denial keeps its own messageurl_privatebut nourl_private_downloadnow gets its download URL fromfiles.info, so a PDF downloads instead of hitting Slack's off-host viewer redirect (which the download refuses). External files skip the lookup entirelyisExternalSlackFileis exported fromlib/internal/slack/file-download.tsand shared byslackFileDownloadUrland the triggerfiles.slack.comURL, so they prove the external-file check rather than passing on the host checkType of Change
Testing
sim-search/live/slack.test.ts: a 403 from the file host yields the file-specific reason and never "Reconnect"; another provider reason passes through; the preview survives bothwebhooks/providers/slack.test.ts: an event with onlyurl_privateresolves and downloadsurl_private_download; an external file triggers nofiles.infolookup and no downloadlib/internal/slack,lib/webhooks,lib/sim-search/live,lib/knowledge/searchsuites pass (1,244 tests); biome; egress-boundary, organization-egress, boundaries, comment-hygiene, test-patterns, file-names, utils, explicit-any, import-specifiers, source-conventions audits passChecklist
test-auditauthoring gate)