Skip to content

improvement(ci): omit unused browser maps from acceptance builds - #10125

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/ci-next-refinements
Nov 17, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/ci-next-refinements

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Omit browser source maps from the acceptance build, whose uploaded artifact already excludes them. Keep ordinary hosted and deployment maps enabled.
  • Include the explicit build option in Turbo's cache key so map modes cannot reuse incompatible outputs.

Type of Change

  • Other: CI resource efficiency

Testing

  • Hosted pre-change check fails for the intended missing opt-out; fixed configuration preserves unset/false defaults and disables maps for true.
  • Real Turbo hashes differ by mode; removing the hash guard loses that distinction.
  • Eight forced complete builds preserve all 1,123 app-route entries. Maximum process RSS averages 2.9% lower and filesystem writes 5.8% lower. Elapsed results overlap; this does not establish a wall-time speedup.
  • Complete hosted PR checks passed, including the candidate artifact's native Chromium/WebKit, HTTP, integration and Electron acceptance. No local builds or test suites ran.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Full hosted CI passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 17, 2026 7:32am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Skips browser source maps when building the shared acceptance artifact.

  • Acceptance builds now skip browser source maps.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Acceptance build: flag true] --> B[Turbo hashes map mode]
  B --> C[Next.js skips browser maps]
  C --> D[Shared acceptance artifact]
  E[Ordinary build: flag unset] --> F[Browser maps stay enabled]
Loading

Reviews (1) · Last reviewed commit: "improvement(ci): omit unused browser map..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Parameter's three neutral findings refer to existing loopback PostgreSQL fixtures in this workflow. The jobs declare disposable test-container credentials, and the reported URLs connect to localhost or 127.0.0.1. This PR changes none of those values; its workflow change adds only the browser-map build option. No live credential is introduced.

@waleedlatif1
waleedlatif1 merged commit e7ff38c into staging Nov 17, 2026
86 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/ci-next-refinements branch November 17, 2026 07:42

This branch was successfully deployed

1 active deployment
Preview — d09c1ee8 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant