Skip to content

improvement(ci): reuse bounded compiler state for acceptance builds - #10127

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/ci-incremental-e2e
Nov 17, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/ci-incremental-e2e

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Reuse incremental Next compiler state only for trusted Blacksmith E2E builders, with a separate recipe/toolchain/event namespace and bounded pre/post-build maintenance.
  • Avoid restoring compiler state when Turbo already has the complete output; keep the build command and every existing acceptance check required.
  • Preserve mounted cache roots and dev-cache ownership. Keep GitHub fallback, forks, and deployment builds cache-off.

Type of Change

  • Performance improvement

Testing

  • Hosted same-source qualification: warm job 227s → 148s; changed-source job 229s → 159s; cold job 225s → 259s. Revalidated actual HTTP title, OpenGraph and JSON-LD across source changes and reversion; identical route inventories. These pairs establish a warm-cache opportunity, not a universal CI speedup.
  • Real mounted-disk lifecycle checks cover nonempty replacement, failed/cancelled producer nonpublication, and bounded cleanup preserving the root. Snapshot freshness and physical eviction are not assumed.
  • Real Node/Bun filesystem CLI regressions and individual guard mutations; real Next config and Turbo mode-hash isolation. Full PR CI passed, including lint, audits, types, tests, database integrations and native acceptance suites.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner November 17, 2026 09:04
@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 17, 2026 9:09am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge with the existing CI checks required.

Summary

This PR adds bounded compiler-cache reuse to trusted Blacksmith acceptance builds.

  • Trusted E2E builds can reuse Next compiler state without skipping the build.
  • Cache cleanup bounds build state while keeping developer cleanup separate.

No actionable issues were found. Tests were inspected but not run. waleedlatif1 explicitly acknowledges the measured cold-build slowdown and defers hosted/deployment cache use pending separate qualification.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Acceptance build] --> B{Trusted Blacksmith runner?}
  B -- No --> F[Run build with compiler cache off]
  B -- Yes --> C{Turbo has complete output?}
  C -- Yes --> G[Run build through Turbo]
  C -- No or uncertain --> D[Mount compiler state]
  D --> E[Check size and clear oversized state]
  E --> G
  G --> H[Check mounted state size again]
  F --> I[Package build without compiler cache]
  H --> I
  I --> J[Existing acceptance checks]
Loading

Reviews (1) · Last reviewed commit: "improvement(ci): reuse bounded compiler ..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Reviewed the neutral Parameter Secret Detection result: all three reported URL forms already exist on the base branch and connect only to disposable loopback CI databases. This change introduces no credential or external database destination. The fixture values and container setup remain unchanged.

@waleedlatif1
waleedlatif1 merged commit d54ce94 into staging Nov 17, 2026
154 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/ci-incremental-e2e branch November 17, 2026 09:27

This branch was successfully deployed

1 active deployment
Preview — 0eee3d71 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant