Repository navigation
fix(gitlab): scale group discovery and permission-aware search - #10138
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[Medium impact] The PR appears safe to merge; no actionable defects were established. SummaryRaises GitLab group discovery to 50,000 projects and adds group-wide search for CSV-backed sources.
No actionable new issues were found. No previous review threads were supplied. The previous-review merge-base check failed, so this review covered the full PR. Tests were inspected but not run.
|
There was a problem hiding this comment.
All reported issues were addressed across 19 files
This PR changes authentication, authorization, or input validation. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 27 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
1b94ceb to
1830196
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
GitLab group sources stopped at 1,000 projects, and searching a large group required walking projects individually. This raises discovery to 50,000 projects and uses native group search for CSV sources, with existing per-project authorization and bounded fallback for unsupported scopes. Administrator-token sources retain their existing project traversal.
CSV uploads and the downloadable exporter now support up to 500,000 data rows and 8 MiB per file, within the existing 10 MiB encoded request limit. The form blocks combined CSV payloads that exceed the encoded request limit before saving. Discovery keeps only bounded project IDs/paths; summary reads avoid loading the full manifest; the exporter writes incrementally and publishes both files only after success. Existing project sources, CSV headers, source IDs, upload endpoints, and revision checks remain compatible.
Product update
Group connections can cover larger namespaces without adding projects individually. GitLab setup and CI documentation describes the limits, search capabilities, continuation behavior, and CI timing. GitLab's own offset/rate limits and the permission payload limits still apply.
Type of Change
Testing
Checklist