Repository navigation
improvement(search): drop unusable citation IDs and title-only previews from Search MCP results - #10143
Merged
Conversation
…ws from Search MCP results
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryThis PR trims Search MCP responses without changing how clients search or read documents.
No actionable issues found. Reviews (1) · Last reviewed commit: "improvement(search): drop unusable citat..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
citationId: no Search MCP tool accepts it and the tool descriptions tell clients to citecitationUrlsearch_workspacecontent(providers fall back to the title when the source has no text)Type of Change
Testing
bun run --cwd apps/sim test lib/knowledge/mcp/server.test.ts lib/sim-search/live/application.test.ts lib/sim-search/live/providers.test.ts: 161 passedserver.tsreverted, the search-shape and read-shape tests fail on the extracitationIdand title-onlycontentChecklist
test-auditauthoring gate)