Skip to content

improvement(search): drop unusable citation IDs and title-only previews from Search MCP results - #10143

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/search-mcp-citation-url
Nov 18, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
improvement/search-mcp-citation-url

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Search MCP results and reads no longer carry citationId: no Search MCP tool accepts it and the tool descriptions tell clients to cite citationUrl
  • The shared live search guidance no longer says "Cite returned citation IDs", which contradicted the MCP tool descriptions; the Assistant keeps its own, more specific citation instruction on search_workspace
  • A search row whose preview is empty or only repeats its title omits content (providers fall back to the title when the source has no text)
  • About 3.5% smaller on a 30-row federated search (measured with the real MCP handler and guidance)

Type of Change

  • Improvement

Testing

  • bun run --cwd apps/sim test lib/knowledge/mcp/server.test.ts lib/sim-search/live/application.test.ts lib/sim-search/live/providers.test.ts: 161 passed
  • Red check: with server.ts reverted, the search-shape and read-shape tests fail on the extra citationId and title-only content
  • Biome clean on the changed files; CI runs type-check and audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 18, 2026 4:15am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

This PR trims Search MCP responses without changing how clients search or read documents.

  • Search MCP results use source links, not generated citation IDs.
  • Search hits skip previews that add nothing beyond their title.

No actionable issues found.

Reviews (1) · Last reviewed commit: "improvement(search): drop unusable citat..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit b61441b into staging Nov 18, 2026
81 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/search-mcp-citation-url branch November 18, 2026 04:25

This branch was previously deployed

1 inactive deployment
Preview — c2a041fc Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant