Skip to content

fix(desktop): show Desktop settings on the organization and account settings surfaces - #10144

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/desktop-settings-org-surface
Nov 18, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/desktop-settings-org-surface

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Desktop settings (quick chat shortcut, notifications, launch at login, updates) were registered only in workspace settings, so anyone on the organization settings surface, or without a workspace, had no way to reach them
  • The Desktop section now also lives on the account plane: the organization settings surface and the standalone account settings list it when the page runs inside the desktop app (hasDesktopSettings(), hydration-safe via useHydrated)
  • The desktop app's Settings menu opens Desktop settings from organization pages too (it already did from workspace pages)
  • The Desktop page's no-bridge redirect is path-relative, so it lands on that surface's General page instead of a broken workspace URL
  • Computer-use controls still need a workspace (they follow the workspace's permission group) and stay hidden off it; Browser and Terminal remain workspace settings

Type of Change

  • Bug fix

Testing

  • New organization navigation test: Desktop is listed only inside the desktop app and /o/<org>/settings/desktop resolves to it; reverting either the hosting or the desktop gate fails it
  • Settings suites (app/o/[organizationId]/settings, components/settings, app/account/settings, desktop settings components): 19 files, 176 tests pass; apps/desktop app-routes tests pass
  • Lint on changed files; type-check and audits in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 18, 2026 4:24am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Desktop settings are now reachable from organization and standalone account settings inside the desktop app.

  • Desktop settings appear in organization and account settings in the desktop app.
  • The desktop menu opens Desktop settings for the last organization.
  • Desktop settings return to General on the same settings surface.

No actionable issues found.

Reviews (1) · Last reviewed commit: "fix(desktop): show Desktop settings on t..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 87541cd into staging Nov 18, 2026
88 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/desktop-settings-org-surface branch November 18, 2026 04:48

This branch was previously deployed

1 inactive deployment
Preview — b1488613 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant