Skip to content

fix(search): widen Slack day modifiers so a member's time zone never empties a date window - #10145

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/slack-day-modifier-margin
Nov 18, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/slack-day-modifier-margin

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Slack RTS reads after:/before: day modifiers in the member's own time zone, exclusive. With a one-day margin, a window that starts at UTC midnight is cut for members west of UTC (and the end for members east of it)
  • Verified against real Slack with a Pacific member: a channel posting every few minutes returned no results for a 00:00–06:00 UTC window (after: named the previous UTC day, which in Pacific time ends at 08:00 UTC); starting the window two hours earlier returned a message from inside the original window
  • Widen both day modifiers by two days, enough for every zone from UTC-12 to UTC+14. The exact after/before timestamps sent alongside, and the local date check on every result, still bound the window

Type of Change

  • Bug fix

Testing

  • New property test: for windows starting at midnight in UTC, ahead of UTC and behind UTC, the day modifiers never exclude part of the window in any member zone. All three cases fail on staging and pass with the fix
  • bun run --cwd apps/sim test lib/sim-search/live/dates.test.ts lib/sim-search/live/slack.test.ts lib/sim-search/live/providers.test.ts: 62 passed
  • Biome clean; CI runs type-check and audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 18, 2026 4:26am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Slack search now widens day-based date bounds by two days so a member’s time zone does not cut into the requested window.

  • Slack date searches cover the requested window across member time zones.

No actionable issues found.

Reviews (2) · Last reviewed commit: "fix(search): widen Slack day modifiers s..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 10b0baa into staging Nov 18, 2026
81 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/slack-day-modifier-margin branch November 18, 2026 04:48

This branch was previously deployed

1 inactive deployment
Preview — c22d4627 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant