Repository navigation
fix(search): widen Slack day modifiers so a member's time zone never empties a date window - #10145
Merged
Merged
Conversation
…empties a date window
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] This PR appears safe to merge. SummarySlack search now widens day-based date bounds by two days so a member’s time zone does not cut into the requested window.
No actionable issues found. Reviews (2) · Last reviewed commit: "fix(search): widen Slack day modifiers s..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
after:/before:day modifiers in the member's own time zone, exclusive. With a one-day margin, a window that starts at UTC midnight is cut for members west of UTC (and the end for members east of it)after:named the previous UTC day, which in Pacific time ends at 08:00 UTC); starting the window two hours earlier returned a message from inside the original windowafter/beforetimestamps sent alongside, and the local date check on every result, still bound the windowType of Change
Testing
bun run --cwd apps/sim test lib/sim-search/live/dates.test.ts lib/sim-search/live/slack.test.ts lib/sim-search/live/providers.test.ts: 62 passedChecklist
test-auditauthoring gate)