Skip to content

improvement(search): name each Search MCP result's sender, owner or organizer - #10153

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/search-mcp-author
Nov 18, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
improvement/search-mcp-author

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Live search results already carry author (Gmail sender, Drive owner, Calendar organizer, Jira/Confluence/GitHub author), but the Search MCP projection dropped it
  • A Gmail search row's preview is only the snippet, so a client could not tell who sent a message without a read; Drive, Jira, Confluence and GitHub previews don't name the author either
  • Search rows now include author when the source names one, alongside the other row-only fields

Type of Change

  • Improvement

Testing

  • server.test.ts search-shape test now expects author on a row that has one and none on a row without; it fails on staging and passes with the change
  • bun run --cwd apps/sim test lib/knowledge/mcp/server.test.ts lib/sim-search/live/application.test.ts: 122 passed
  • Biome clean; CI runs type-check and audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 18, 2026 5:50am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; no actionable issues were found.

Summary

Search MCP results now include the source’s author, sender, owner, or organizer when available.

  • Search results show a source's sender, owner, or organizer when known.

No actionable issues found.

Reviews (1) · Last reviewed commit: "improvement(search): name each Search MC..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit df44adc into staging Nov 18, 2026
60 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/search-mcp-author branch November 18, 2026 05:53

This branch was previously deployed

1 inactive deployment
Preview — 77b0abbf Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant