Repository navigation
fix(integrations): validate pinecone, qdrant, elasticsearch and zep - #10164
Conversation
Pinecone fetch sends one ids query param per vector, search text targets __default__ when no namespace is set and sends rerank.query as a string. Qdrant, Elasticsearch and Zep path segments are encoded and dot segments rejected.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The reviewed changes appear safe to merge. SummaryThis PR fixes request formats and URL paths for Pinecone, Qdrant, Elasticsearch, and Zep. Both earlier findings are addressed, and no new actionable issues were found.
Reviews (2) · Last reviewed commit: "fix(integrations): keep exact ids in enc..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 23 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…e a pinecone search namespace
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
1 issue found across 27 files
Confidence score: 3/5
delete_document.tstrimsparams.index, so a value likelogscan silently target and delete fromlogsinstead. Preserve the supplied value or reject surrounding whitespace across all four operations.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/tools/elasticsearch/delete_document.ts">
<violation number="1" location="apps/sim/tools/elasticsearch/delete_document.ts:81">
P2: This trims `params.index` before encoding, so `logs ` silently targets `logs` (including on delete). Preserve the supplied value or reject surrounding whitespace across all four operations.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Summary
Validates the Pinecone, Qdrant, Elasticsearch, Algolia, Convex, Tinybird, Databricks, Mem0, Zep and RabbitMQ integrations against each vendor's official API reference or machine-readable spec (Pinecone
2025-01OpenAPI, Mem0 and Zep v3 API references, Databricks SDK service definitions, RabbitMQ management plugin source), and fixes what was wrong.safeUrlPathSegmentgains apreserveWhitespaceoption so exact-match IDs (Elasticsearch document IDs, Zep IDs, Pinecone namespaces, Qdrant collections) keep surrounding whitespace while dot segments are still rejected.__default__namespace alias is documented for newer API versions; this integration pins2025-01, where it could not be verified, so a blank Search With Text namespace is rejected rather than guessed.modeandminRating, which the current v3 reference no longer lists (the API ignores unknown query params). RabbitMQ's default exchange is addressed with an empty path segment; the broker also accepts theamq.defaultalias, but the public reference documents neither, so it was not changed.Release notes
Pinecone
undefinedand silently returned no results.{"text": "..."}is now sent as the plain string Pinecone expects..or..is rejected before the request is sent.Qdrant
.or..is rejected on all three operations before the request is sent.Elasticsearch
.or..is rejected before the request is sent. Before, Delete Document with ID..could send a DELETE to the index itself. Document IDs that contain/now reach the right document. Document IDs are still sent exactly as entered, including surrounding spaces.Zep
/or other special characters reach the right thread or user, and.or..is rejected before the request is sent. IDs are still sent exactly as entered.