Skip to content

fix(integrations): validate google maps, google translate, google bigquery, google books, google appsheet and google pagespeed - #10165

Merged
waleedlatif1 merged 3 commits into
stagingfrom
fix/validate-google-non-workspace
Nov 18, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
fix/validate-google-non-workspace

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Validates the non-Workspace Google integrations (Google Search, Google Ads, AppSheet, BigQuery, Books, Maps, PageSpeed and Translate) against Google's discovery documents (Custom Search, PageSpeed, Translate v2, Books, BigQuery v2, Google Ads v24, Solar, Air Quality, Pollen, Places, Address Validation, Roads) and the official API reference pages. The fixes are below.

  • Each tool's endpoint, method, params, body, response parsing and outputs was checked, along with block mappers on both the canvas and the Agent tool-call path. Fields that could not be verified were left unchanged.
  • Google Search and Google Ads were validated and need no change.
  • No block type, subBlock, operation, tool, param or output id was renamed or removed, and no OAuth scope was added. Saved workflows send the same requests as before. The exceptions are the bug fixes below: Google Maps coordinates, a PageSpeed category list with a stray comma, and IDs that are now validated before the request is sent.
  • Unverified: AppSheet documents its Action response as { "Rows": [...] }, but community reports show Find returning a bare row array. Both shapes are now read. Live credentials are needed to confirm which one the API sends.
  • Unverified: PageSpeed's discovery document lists category enums as BEST_PRACTICES and so on, while the tool sends Lighthouse ids such as best-practices. The unauthenticated quota is zero, so this could not be probed. Left unchanged.

Release notes

Google Maps

  • Reverse Geocode, Elevation and Timezone now use their own Latitude/Longitude fields. Before, a value left in the Air Quality/Pollen/Solar/Nearby Places coordinate fields of the same block replaced them, and the request went to the wrong location.
  • Solar Potential's Minimum Imagery Quality now offers Low. The empty option is renamed "Default (High only)", because Google returns only high-quality imagery when no minimum is set. Saved values are unchanged.

Google Translate

  • New advanced Text Format option (Default (HTML), Plain text, HTML). Choose Plain text to get apostrophes and other special characters back as plain characters instead of HTML entities such as '. Saved blocks keep Google's HTML default.

Google BigQuery

  • Project, dataset, table and job IDs are now validated before the request is sent. Before, an ID that was empty, ., .., or contained / was sent as part of the URL path. Now it fails with a clear error.

Google Books

  • Get Volume Details now encodes the volume ID. A volume ID containing ?, # or / can no longer change the request URL.

Google AppSheet

  • Find, Add, Edit and Delete Rows also read a response body that is a bare array of rows. Before, that body came back as zero rows.

Google PageSpeed

  • A Categories list with an empty entry (for example a trailing comma) no longer sends an empty category value.

…query, google books, google appsheet and google pagespeed
@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 18, 2026 6:30pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 27 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new blocking issues were found.

Summary

This PR fixes Google integration requests and response reading, adds translation format choices, and expands Solar imagery choices. The latest update keeps numeric BigQuery project IDs consistent between request URLs and bodies.

  • Google Maps sends coordinates from the fields for the selected operation.
  • BigQuery checks project, dataset, table, and job IDs before building request URLs.
  • AppSheet row actions return rows from bare-array responses.
  • Google Translate lets users choose plain text or HTML output.
  • Google Books keeps volume IDs inside one request path segment.
  • PageSpeed skips empty entries in its category list.
  • Google Maps Solar offers Low imagery quality and names its default.

No new actionable issues found in the changes since the previous review.

Reviews (3) · Last reviewed commit: "fix(integrations): accept a numeric BigQ..." · Reviewed by Greptile

Comment thread apps/sim/blocks/blocks/google_maps.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 28 files

Confidence score: 3/5

  • In create_table.ts, invalid tableId values can still reach Google because the ID is sent only in the JSON body. Validate the ID before constructing the request.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/tools/google_bigquery/create_table.ts">

<violation number="1" location="apps/sim/tools/google_bigquery/create_table.ts:70">
P2: This change still lets invalid `tableId` values reach Google because create-table carries the ID only in the JSON body. Validate `tableId` before constructing the request, while retaining the trimmed raw value in `tableReference` rather than using the encoded helper output.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/google_bigquery/query.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 28 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit db05a26 into staging Nov 18, 2026
84 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/validate-google-non-workspace branch November 18, 2026 20:09

This branch was previously deployed

1 inactive deployment
Preview — c847218c Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant