Repository navigation
fix(integrations): validate google maps, google translate, google bigquery, google books, google appsheet and google pagespeed - #10165
Conversation
…query, google books, google appsheet and google pagespeed
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
All reported issues were addressed across 27 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[Medium impact] The PR appears safe to merge; no new blocking issues were found. SummaryThis PR fixes Google integration requests and response reading, adds translation format choices, and expands Solar imagery choices. The latest update keeps numeric BigQuery project IDs consistent between request URLs and bodies.
No new actionable issues found in the changes since the previous review. Reviews (3) · Last reviewed commit: "fix(integrations): accept a numeric BigQ..." · Reviewed by Greptile |
… type the Low solar quality
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
1 issue found across 28 files
Confidence score: 3/5
- In
create_table.ts, invalidtableIdvalues can still reach Google because the ID is sent only in the JSON body. Validate the ID before constructing the request.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/tools/google_bigquery/create_table.ts">
<violation number="1" location="apps/sim/tools/google_bigquery/create_table.ts:70">
P2: This change still lets invalid `tableId` values reach Google because create-table carries the ID only in the JSON body. Validate `tableId` before constructing the request, while retaining the trimmed raw value in `tableReference` rather than using the encoded helper output.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Validates the non-Workspace Google integrations (Google Search, Google Ads, AppSheet, BigQuery, Books, Maps, PageSpeed and Translate) against Google's discovery documents (Custom Search, PageSpeed, Translate v2, Books, BigQuery v2, Google Ads v24, Solar, Air Quality, Pollen, Places, Address Validation, Roads) and the official API reference pages. The fixes are below.
{ "Rows": [...] }, but community reports show Find returning a bare row array. Both shapes are now read. Live credentials are needed to confirm which one the API sends.BEST_PRACTICESand so on, while the tool sends Lighthouse ids such asbest-practices. The unauthenticated quota is zero, so this could not be probed. Left unchanged.Release notes
Google Maps
Google Translate
'. Saved blocks keep Google's HTML default.Google BigQuery
.,.., or contained/was sent as part of the URL path. Now it fails with a clear error.Google Books
?,#or/can no longer change the request URL.Google AppSheet
Google PageSpeed
categoryvalue.