Skip to content

fix(integrations): validate cloudtrail, codepipeline, sqs and ssm - #10168

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/validate-aws-remainder
Nov 18, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/validate-aws-remainder

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Validates the AWS integrations the earlier AWS sweep (#9952, #9961) did not cover: CloudTrail, CodePipeline, SQS, Systems Manager (SSM) and AppConfig. Each was checked against the AWS SDK v3 types (@aws-sdk/client-* 3.1162) and the AWS API references, the same way #9952 checked the other AWS services.

  • Every operation's request fields, limits, pagination tokens, response mapping, tool outputs, contracts and block mappers were checked. Every client already builds its config with awsClientConfig, so all five already send through organizationAwsRequestHandler() and sign saved-credential session tokens. SQS's hosted queue-URL guard already covers every operation that takes a queue URL, using the SDK partition hosts.
  • Every block operation was probed for the raw-input merge trap ({ ...rawInputs, ...mappedParams }): a value saved in a field for another operation must never reach the request. Three leaks were found and fixed (below). AppConfig and CloudTrail had none.
  • AppConfig: validated, no change needed.
  • Compatibility: no block type, subBlock id, operation, tool id, param or output was renamed or removed, and no default changed. Canvas requests for saved workflows are unchanged except for the stale-value fixes listed below, where the old request carried another operation's value.
  • Left as is:
    • AppConfig Update Application/Environment/Configuration Profile send a blanked Description as "", which clears it on AWS. That may be intended, so it is unchanged.
    • AppConfig List Configuration Profiles returns description and retrievalRoleArn as null because the list API does not return them. They are not declared outputs, so nothing promises them.

Release notes

CloudTrail

  • List Event Data Stores: AWS no longer returns status, selectors, multi-Region, organization, retention, termination protection or timestamps from this list, so those fields are always empty. Their descriptions now say so and point to Get Event Data Store, which still returns them. The fields stay in the output.

CodePipeline

  • Max Results is now read only by the list operations. Before, an invalid value left in that hidden field failed every other operation, such as Start Execution.

SQS

  • Receive Message no longer sends the Visibility Timeout saved for Change Message Visibility when its own Visibility Timeout is empty. Received messages now use the queue's default timeout as intended.
  • List Message Move Tasks no longer sends the Max Results saved for List Queues. A value above 10 used to fail the run.

Systems Manager

  • Get Parameters By Path, Describe Instance Information, Describe Instance Patches and Describe Instance Patch States no longer send the Max Results saved for the other list operations when their own Max Results is empty. Values outside their ranges (1-10, 5-50, 10-100) used to fail the run.

Testing

  • New cases in blocks/blocks/aws-stale-inputs.test.ts for the SQS receive, SQS move-task and SSM by-path leaks. All three fail on the pre-fix mappers.
  • vitest over the CloudTrail, CodePipeline, SQS and SSM block, lib/internal and tool tests passes.
  • check-block-registry.ts origin/staging, check:tool-metadata, check:docs, check:integration-catalog, check:mapper-operation, check:tool-param-reachability, check:tool-request-boundary, check:explicit-any, the canvas-sentence check for all five blocks, and biome pass. Type-check and check:audits run in CI.

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 18, 2026 6:28pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/sqs.ts Resolved
Comment thread apps/sim/blocks/blocks/sqs.ts Resolved
@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The reviewed changes appear safe to merge.

Summary

This PR keeps stale AWS block settings out of requests and clarifies CloudTrail list outputs.

  • CodePipeline checks the page limit only for list operations.
  • SQS requests use the timeout and limit for their selected operation.
  • Systems Manager requests use the limit for their selected operation.
  • CloudTrail list results point to a separate lookup for store details.

No new actionable issues were found in the changes since the previous review.

Reviews (2) · Last reviewed commit: "fix(integrations): keep the agent's limi..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit f345300 into staging Nov 18, 2026
84 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/validate-aws-remainder branch November 18, 2026 20:09

This branch was previously deployed

1 inactive deployment
Preview — ce98d276 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant