Repository navigation
fix(integrations): validate cloudtrail, codepipeline, sqs and ssm - #10168
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[Medium impact] The reviewed changes appear safe to merge. SummaryThis PR keeps stale AWS block settings out of requests and clarifies CloudTrail list outputs.
No new actionable issues were found in the changes since the previous review. Reviews (2) · Last reviewed commit: "fix(integrations): keep the agent's limi..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This was referenced Nov 18, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validates the AWS integrations the earlier AWS sweep (#9952, #9961) did not cover: CloudTrail, CodePipeline, SQS, Systems Manager (SSM) and AppConfig. Each was checked against the AWS SDK v3 types (
@aws-sdk/client-*3.1162) and the AWS API references, the same way #9952 checked the other AWS services.awsClientConfig, so all five already send throughorganizationAwsRequestHandler()and sign saved-credential session tokens. SQS's hosted queue-URL guard already covers every operation that takes a queue URL, using the SDK partition hosts.{ ...rawInputs, ...mappedParams }): a value saved in a field for another operation must never reach the request. Three leaks were found and fixed (below). AppConfig and CloudTrail had none."", which clears it on AWS. That may be intended, so it is unchanged.descriptionandretrievalRoleArnasnullbecause the list API does not return them. They are not declared outputs, so nothing promises them.Release notes
CloudTrail
CodePipeline
SQS
Systems Manager
Testing
blocks/blocks/aws-stale-inputs.test.tsfor the SQS receive, SQS move-task and SSM by-path leaks. All three fail on the pre-fix mappers.vitestover the CloudTrail, CodePipeline, SQS and SSM block,lib/internaland tool tests passes.check-block-registry.ts origin/staging,check:tool-metadata,check:docs,check:integration-catalog,check:mapper-operation,check:tool-param-reachability,check:tool-request-boundary,check:explicit-any, the canvas-sentence check for all five blocks, and biome pass. Type-check andcheck:auditsrun in CI.