Skip to content

fix(integrations): validate clerk, crowdstrike, infisical, ketch, onepassword, persona, rootly - #10171

Merged
waleedlatif1 merged 6 commits into
stagingfrom
fix/validate-security-identity
Nov 18, 2026
Merged

waleedlatif1 merged 6 commits into
stagingfrom
fix/validate-security-identity

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Validates the CrowdStrike, Rootly, Tailscale, Infisical, 1Password, Vanta, Ketch, Clerk, Persona and Checkr integrations against each vendor's official API spec, and fixes what was wrong.

  • Every tool's endpoint, method, query and body params, response parsing and outputs was checked against the vendor's machine-readable spec where one exists: Rootly, Tailscale, Infisical, Vanta (Manage Vanta), Persona (2025-12-08, the pinned version), Checkr, Clerk BAPI and the 1Password Connect OpenAPI specs; the falconpy/gofalcon definitions for CrowdStrike; the official ketch-web-api SDK plus unauthenticated probes for Ketch; and @1password/sdk types for 1Password service accounts. Claims that could not be verified were left unchanged.
  • Validated with no change needed: Tailscale, Vanta, Checkr.
  • Canvas requests for saved workflows are unchanged, except for the bug fixes listed below. No block type, subBlock, operation, tool, param or output id was renamed or removed, and no OAuth scope was added.
  • Left for a product decision:
    • Clerk: the tools send no Clerk-API-Version header. Newer BAPI versions moved user and organization metadata out of the PATCH bodies, so pinning a version would change what Update User/Organization accept.
    • 1Password service accounts: item outputs do not include secure-note text. How to surface it needs a decision.
  • Unverified, left unchanged:
    • Ketch: right codes, which are defined per org.
    • CrowdStrike: the detection_suppress/detection_unsuppress host actions.
    • Rootly: whether an empty {data:{}} body is accepted on alert acknowledge/resolve/escalate.

Release notes

Persona

  • Create Report now sends the country code under the field each report type expects: address-country-code for watchlist, country-code for adverse media and politically exposed person reports. Before, the two were swapped, so the country filter was silently ignored.

Ketch

  • Set Consent now records a granted consent as granted. Before, "allowed": "granted" (the value in Sim's own example) was saved by Ketch as denied, because Ketch only accepts "true"/"false". granted/denied (any case) and booleans are now converted, so saved workflows that send granted now record the consent they intended. Any other value is sent unchanged, as before.
  • Errors now show Ketch's own message (for example "user is required for unauthenticated right invocations") instead of an unreadable object.
  • Invoke Right now requires User Data (email, first name, last name), which Ketch needs for a rights request, and the field is no longer hidden under advanced settings. Runs without it were already rejected by Ketch.
  • The vendors output of Get Consent is described as a list of vendor IDs, matching what Ketch returns.

Infisical

  • When an environment requires approval for secret changes, Create, Update and Delete Secret now return the pending change request in a new approval output. Before, the change request's ID and timestamps were reported as the secret's.
  • A secret name of . or .. is now refused instead of being sent to a different API path.

Clerk

  • List Users no longer filters by a username, external ID or phone number left over from a Create or Update User setup on the same block, and its own filter fields always take effect.
  • User, organization, session, identifier, template, actor-token and provider IDs that contain a path separator or are ./.. are now rejected instead of reaching a different Clerk endpoint. Valid IDs are unaffected.

CrowdStrike

  • Update Alerts: the Status field now starts at "No change", so adding a comment or tag or changing the assignee no longer resets an alert's status to New. Saved steps keep the status they were saved with.

1Password

  • Service-account mode: Get Vault and List Vaults now return each vault's description, item count, type and version counters. Before, these came back as placeholders (no description, 0 items, always USER_CREATED). Vaults are listed with decryptDetails so the description is available.
  • Connect mode: vault, item and file IDs are now validated and encoded in request paths, and empty tags are no longer sent on Create Item.

Rootly

  • Errors now show Rootly's message instead of only the HTTP status: the error title, plus the detail when Rootly sends one (for example "Unprocessable Entity: Title is too long", or "Invalid token").
  • IDs used in request paths are now validated and encoded. Normal IDs are unaffected.

Testing

  • Regression tests for Persona (country-code field), Ketch (granted consent, unknown values passed through, error envelope), Rootly (error message), Infisical (approval response, dot-segment names), Clerk (stale List Users filters), CrowdStrike (seeded status) and 1Password (vault normalization). Each was confirmed to fail on the pre-fix code.
  • Ran the touched test files, biome, check:tool-metadata, check:docs, check:integration-catalog, check:mapper-operation, check:utils, check:explicit-any, check:tool-param-reachability, check:tool-request-boundary, check:comment-hygiene, check:bare-icons, check:icon-path-precision and check-canvas-sentences for every block locally. CI runs type-check and the full suite.

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 18, 2026 9:01pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 96 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/ketch/set_consent.ts Resolved
@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The reviewed changes appear safe to merge.

Summary

This PR fixes integration requests, returned data, and editor defaults across seven services.

  • Persona reports send the country code under the field each report type expects.
  • Ketch consent writes use the values Ketch expects, and rights requests require user data.
  • Infisical secret writes report pending approvals separately and reject dot-only names.
  • Clerk user filters use their own fields, and path IDs reject unsafe values.
  • CrowdStrike alert updates start with no status change selected.
  • 1Password vault results include more details, and request paths use checked IDs.
  • Rootly request paths reject unsafe IDs before calling the vendor.
  • Rootly failures show the vendor's title and useful detail.

No new actionable issues were found. The earlier approval-mapper type mismatch is fixed. waleedlatif1 explicitly leaves Clerk API version pinning and 1Password secure-note text for a product decision; unverified vendor behavior stays unchanged.

Reviews (4) · Last reviewed commit: "fix(integrations): coerce rootly path id..." · Reviewed by Greptile

Comment thread apps/sim/tools/infisical/utils.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 96 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 98 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 force-pushed the fix/validate-security-identity branch from 27d7e53 to 8d254ca Compare November 18, 2026 20:21
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 98 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 force-pushed the fix/validate-security-identity branch from 87dfc2a to f0b0800 Compare November 18, 2026 20:56
@waleedlatif1
waleedlatif1 merged commit e759769 into staging Nov 18, 2026
57 of 58 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/validate-security-identity branch November 18, 2026 20:58

This branch was successfully deployed

1 active deployment
Preview — f0b0800b Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant