Repository navigation
fix(integrations): validate mongodb, neo4j and upstash - #10172
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge. SummaryThis PR stops oversized MongoDB and Neo4j results while reading them and adds stricter checks for Upstash request arguments.
No new actionable issues were found. Reviews (3) · Last reviewed commit: "fix(integrations): drop the row cap; str..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 53 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
ad60e62 to
603e208
Compare
603e208 to
f8f886e
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 24 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…ferred tls as documented, tune truncation hints
…nd fail at the response size limit
af39eaa to
08d75c6
Compare
Summary
Validates the PlanetScale, PostgreSQL, MySQL, SQL Server, Oracle Database, ClickHouse, MongoDB, Neo4j, Redis and Upstash integrations against each vendor's driver docs, server docs and API spec (PlanetScale's OpenAPI spec, Upstash's REST API docs, ClickHouse's HTTP interface and system tables). It also checks the saved-connection wiring from #9929, the host/SSRF guards, and memory-load safety. The PR fixes what was wrong.
PayloadSizeLimitError(same label and limit) that the executor's response-body limit already threw for such results. MongoDB closes the server cursor and Neo4j discards the remaining records, so an oversized result is never loaded in full. A result that fits is returned unchanged, with no row cap. The budget counts the rows array exactly as it serializes (UTF-8 bytes plus brackets and commas) against the full 10 MiB, so it only fails results the response limit already rejected. Neo4j delete only waits for the summary, as before, because its response carries no records..or..are rejected, and integer arguments (EX, EXPIRE seconds, INCRBY increment, LRANGE start/stop) must be integers. URL parsing resolves a dot segment, encoded or not, soHGET .. flushallbecame a request to/flushall, and an increment such as../../flushalldid the same.system.*column checked against the docs; responses are already byte-capped) and Redis.KEYS,HGETALL,LRANGEand the generic command read whatever the server returns, because ioredis has no reply-size limit.Release notes
MongoDB
Neo4j
Upstash
.or..is now rejected with a clear error. Before, the request could reach a different Redis command (for example, Get Hash Field with key..and fieldflushallran FLUSHALL).