Repository navigation
fix(integrations): validate grafana, posthog - #10173
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[Medium impact] The PR appears safe to merge; no new blocking issues were found. SummaryThis PR fixes PostHog tool results and rollout inputs, tightens Grafana panel checks, and adds an alert-rule filter.
As noted by waleedlatif1, Update Feature Flag’s rollout change remains deferred because it needs an update that preserves existing targeting. Reviews (6) · Last reviewed commit: "test(posthog): use the shared jsonRespon..." · Reviewed by Greptile |
|
@cubic-dev-ai review this PR |
There was a problem hiding this comment.
All reported issues were addressed across 27 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
f77f8da to
9e4109a
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 28 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
9257787 to
1a57f02
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 28 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
1a57f02 to
ba26ce5
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 28 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
…rray, map the alert rule UID
…eep blank grafana panels empty
…ollouts for the tool to read
ba26ce5 to
0cece63
Compare
Summary
Validates the Grafana, Dynatrace, New Relic, Logfire, LogRocket, LangSmith, LaunchDarkly, PostHog, Splunk, UptimeRobot and Downdetector integrations against each vendor's official API docs, and fixes what was wrong in Grafana and PostHog.
public/openapi3.json) and itspkg/apisource, the PostHog OpenAPI schema and DRF serializers, the LangSmith, LaunchDarkly, UptimeRobot v3 and Downdetector v2 OpenAPI specs, the Logfire SDK query client and query API docs, and New Relic's change-tracking NerdGraph docs.rollout_percentage, which PostHog ignores. A correct fix needs a read-modify-write of the flag's release conditions, or PostHog'sset_release_condition_rolloutaction with the flag version. Rebuildingfiltersfrom the percentage alone would delete the flag's existing targeting, so this is unchanged.Release notes
PostHog
150or50%) now fails with a clear error. Before, it was silently ignored. Before, PostHog ignored it and the flag was created without that rollout. When Filters is also set, the percentage applies to each release condition that does not set its own.Grafana
alertUID, and each annotation now returnsalertUID. Grafana is moving off the legacy numeric Alert ID filter, which is still sent unchanged when set.