Skip to content

fix(integrations): validate grafana, posthog - #10173

Merged
waleedlatif1 merged 7 commits into
stagingfrom
fix/validate-observability
Nov 18, 2026
Merged

waleedlatif1 merged 7 commits into
stagingfrom
fix/validate-observability

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Validates the Grafana, Dynatrace, New Relic, Logfire, LogRocket, LangSmith, LaunchDarkly, PostHog, Splunk, UptimeRobot and Downdetector integrations against each vendor's official API docs, and fixes what was wrong in Grafana and PostHog.

  • Checked against the published specs where they exist: the Grafana OpenAPI (public/openapi3.json) and its pkg/api source, the PostHog OpenAPI schema and DRF serializers, the LangSmith, LaunchDarkly, UptimeRobot v3 and Downdetector v2 OpenAPI specs, the Logfire SDK query client and query API docs, and New Relic's change-tracking NerdGraph docs.
  • No change was needed for Dynatrace, New Relic, Logfire, LogRocket, LangSmith, LaunchDarkly, Splunk, UptimeRobot or Downdetector. Regional and instance host handling is unchanged everywhere.
  • PostHog: 15 tools returned their data without the tool-result envelope. 14 of them failed every run with "Block execution of … failed with no error message", and Delete Feature Flag succeeded with empty output. They now return a normal result. A new test runs every PostHog tool's response handling and fails on the old code.
  • No block type, subBlock, operation, tool, param or output id was renamed or removed, and no OAuth scope was added. Saved workflows send the same requests, except for the bug fixes listed below.
  • Left for a product decision: PostHog Update Feature Flag's Rollout Percentage is sent as a top-level rollout_percentage, which PostHog ignores. A correct fix needs a read-modify-write of the flag's release conditions, or PostHog's set_release_condition_rollout action with the flag version. Rebuilding filters from the percentage alone would delete the flag's existing targeting, so this is unchanged.

Release notes

PostHog

  • List/Get/Create/Update Feature Flag, Evaluate Feature Flags, List/Get/Create/Update Experiment, List/Get/Update Event Definition and List/Get/Update Property Definition now work. Every run used to fail with "failed with no error message" even when PostHog accepted the request.
  • Delete Feature Flag now returns its confirmation message. It already succeeded before, but its output was empty.
  • Create Feature Flag: Rollout Percentage now applies when it is a number from 0 to 100, including 0 and numeric text from an agent. It is sent as the flag's release condition. An empty Rollout Percentage still sends no release condition, so saved blocks that leave it blank behave as before. A value that is not a number from 0 to 100 (for example 150 or 50%) now fails with a clear error. Before, it was silently ignored. Before, PostHog ignored it and the flag was created without that rollout. When Filters is also set, the percentage applies to each release condition that does not set its own.
  • Delete Person now reports success when PostHog queues the deletion. Before, a queued deletion was reported as "No matching person found to delete".

Grafana

  • Create Dashboard: invalid Panels JSON now fails with a clear error. Before, the dashboard was silently created with no panels. Panels JSON that is not an array is also rejected. An empty or whitespace-only Panels value still creates a dashboard with no panels. Panels from a block reference that already resolved to an array are sent as given.
  • List Annotations has a new optional Alert Rule UID filter (advanced), sent as alertUID, and each annotation now returns alertUID. Grafana is moving off the legacy numeric Alert ID filter, which is still sent unchanged when set.

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 18, 2026 8:27pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new blocking issues were found.

Summary

This PR fixes PostHog tool results and rollout inputs, tightens Grafana panel checks, and adds an alert-rule filter.

  • PostHog tools return results in the shape workflows expect.
  • PostHog feature-flag creation applies valid rollout percentages.
  • PostHog person deletion reports queued requests as successful.
  • Grafana dashboard creation rejects invalid panel input instead of dropping it.
  • Grafana annotation searches can filter by alert rule UID and return it.

As noted by waleedlatif1, Update Feature Flag’s rollout change remains deferred because it needs an update that preserves existing targeting.

Reviews (6) · Last reviewed commit: "test(posthog): use the shared jsonRespon..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 27 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/grafana.ts Resolved
@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 27 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 27 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

Comment thread apps/sim/blocks/blocks/posthog.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 28 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/posthog.ts Resolved
@waleedlatif1
waleedlatif1 force-pushed the fix/validate-observability branch from 9257787 to 1a57f02 Compare November 18, 2026 19:46
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

Comment thread apps/sim/tools/posthog/posthog.test.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 28 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 28 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 force-pushed the fix/validate-observability branch from ba26ce5 to 0cece63 Compare November 18, 2026 20:22
@waleedlatif1
waleedlatif1 merged commit 48594d4 into staging Nov 18, 2026
57 of 58 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/validate-observability branch November 18, 2026 20:26

This branch was successfully deployed

1 active deployment
Preview — 0cece631 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant