Repository navigation
fix(computer-use): show computer use controls on organization Desktop settings - #10176
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[Medium impact] The reviewed changes appear safe to merge. SummaryComputer Use settings now follow the workspace or organization shown in the settings page, while account settings keep device controls hidden.
The earlier concern about the organization test is addressed: it now checks the organization request path without replacing the query hook. No new actionable issues were found. Reviews (3) · Last reviewed commit: "fix(computer-use): exercise the real ava..." · Reviewed by Greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
useUserPermissionConfig(workspaceId), which needs a workspace, so they never appeared. An organization-only user could not turn computer use on even though organization chats support itGET /api/workspaces/[id]/computer-use/availabilityandGET /api/organizations/[id]/computer-use/availability; the routes only parse and present, no new authorizationuseComputerUseAvailability(owner)reads the route's owner: the workspace on workspace settings, the organization on organization settings, and none on account settings, where the device controls stay hidden (no permission group governs them there)Type of Change
Testing
computer-use.test.tsx: controls withheld when the owner's group withholds computer use, shown for an organization owner, withheld without an owner, withheld until the read settles; the organization case fails without the organization branchcapabilities.test.ts:computer_use.useis denied bydisableComputerUseandhideCopilot(coverage previously carried by the component test)check:api-validation:strict,check:boundaries,check:permission-group-enforcement,check:application-graph,check:unused-exports, React Query pattern audit, biomeChecklist
test-auditauthoring gate)