Skip to content

fix(computer-use): show computer use controls on organization Desktop settings - #10176

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/computer-use-settings-owner
Nov 18, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/computer-use-settings-owner

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Desktop settings now also render on the organization and account settings surfaces, but the Computer Use controls there gated on useUserPermissionConfig(workspaceId), which needs a workspace, so they never appeared. An organization-only user could not turn computer use on even though organization chats support it
  • Exposes the existing availability use cases (the same ones the chat payload consults) through GET /api/workspaces/[id]/computer-use/availability and GET /api/organizations/[id]/computer-use/availability; the routes only parse and present, no new authorization
  • useComputerUseAvailability(owner) reads the route's owner: the workspace on workspace settings, the organization on organization settings, and none on account settings, where the device controls stay hidden (no permission group governs them there)
  • The query lives under the permission-group keys, so saving a group refreshes it as before

Type of Change

  • Bug fix

Testing

  • computer-use.test.tsx: controls withheld when the owner's group withholds computer use, shown for an organization owner, withheld without an owner, withheld until the read settles; the organization case fails without the organization branch
  • capabilities.test.ts: computer_use.use is denied by disableComputerUse and hideCopilot (coverage previously carried by the component test)
  • check:api-validation:strict, check:boundaries, check:permission-group-enforcement, check:application-graph, check:unused-exports, React Query pattern audit, biome

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 18, 2026 6:29pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The reviewed changes appear safe to merge.

Summary

Computer Use settings now follow the workspace or organization shown in the settings page, while account settings keep device controls hidden.

  • Organization Desktop settings can show Computer Use controls.

The earlier concern about the organization test is addressed: it now checks the organization request path without replacing the query hook. No new actionable issues were found.

Reviews (3) · Last reviewed commit: "fix(computer-use): exercise the real ava..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 241e5b0 into staging Nov 18, 2026
60 of 62 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/computer-use-settings-owner branch November 18, 2026 18:34
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview — c051d66b Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant