Repository navigation
fix(integrations): validate polymarket, kalshi, sftp, ssh, smtp, jupyter and temporal - #10181
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[Medium impact] The changes since the previous review appear safe to merge. SummaryThis PR restores Polymarket data requests and fixes saved-input leaks, remote paths, SSH output, and SMTP encryption across the affected integrations.
Reviews (7) · Last reviewed commit: "fix(polymarket): mark the next-page curs..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 45 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
f53a748 to
37ec450
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 46 files
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Turn on auto-fix | Re-trigger cubic
37ec450 to
6b754b3
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 47 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
9c34c16 to
fadeab9
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 49 files
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 49 files
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 49 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
c920a2b to
453b79d
Compare
453b79d to
7af7f9c
Compare
…s, and prove STARTTLS against a real SMTP server
…ents and Polymarket activity
…rt=0 as full history
7af7f9c to
b9393ed
Compare
Summary
Validates the Dagster, Fivetran, Temporal, Jupyter, SFTP, SSH, SMTP, Kalshi and Polymarket integrations against each vendor's machine-readable spec (Dagster GraphQL schema, Fivetran OpenAPI, Temporal
openapiv2.json, Kalshiopenapi.yaml, Polymarket Gamma/CLOB/Data API v2 specs) and, for the protocol integrations, against the installedssh2andnodemailersources. It fixes what was wrong.toolCallArg). Each fix has a regression test that fails on the old code.safeUrlPathSegment, so.and..are rejected. Kalshi's signed path uses the same encoded value as the request URL./portfolio/orderswrite endpoints. Its spec says create, cancel and amend now return410 Gone. The replacement (/portfolio/events/orders) uses a different trading model: a single-bookbid/askside, requiredtime_in_forceandself_trade_prevention_type, and no market orders. Translating yes/no + buy/sell orders into it changes what gets traded, so it is not guessed here. Kalshi Create/Cancel/Amend Order keep failing until that is decided.Release notes
Polymarket
410 Gone. These operations now use the Data API v2 and keep the same outputs.nextCursoroutput. A newhasMoreoutput says whether another page exists. Polymarket no longer accepts Offset, and a non-zero Offset now fails with Polymarket's message pointing to Cursor.status..or..instead of calling a different endpoint.Kalshi
.or..are rejected before the request is signed.SFTP
%(for example100% done.csv) now work instead of being rejected as path traversal. Other escapes in the same path, such as%20, still decode...(for example/data/..) is now rejected like any other parent-directory path, so an upload or recursive delete can no longer reach the parent directory.SSH
0755unless an agent passes permissions.�) when a character spans two output chunks.SMTP
Jupyter
file) as the session type when Session Type is empty, so sessions are created as notebook sessions again.Temporal
.or..are rejected instead of calling a different endpoint. IDs that contain/still work.