Skip to content

fix(integrations): validate polymarket, kalshi, sftp, ssh, smtp, jupyter and temporal - #10181

Merged
waleedlatif1 merged 8 commits into
stagingfrom
fix/validate-data-ops-remote
Nov 18, 2026
Merged

waleedlatif1 merged 8 commits into
stagingfrom
fix/validate-data-ops-remote

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Validates the Dagster, Fivetran, Temporal, Jupyter, SFTP, SSH, SMTP, Kalshi and Polymarket integrations against each vendor's machine-readable spec (Dagster GraphQL schema, Fivetran OpenAPI, Temporal openapiv2.json, Kalshi openapi.yaml, Polymarket Gamma/CLOB/Data API v2 specs) and, for the protocol integrations, against the installed ssh2 and nodemailer sources. It fixes what was wrong.

  • Every Dagster GraphQL document validates against the current schema, and every Fivetran and Kalshi read request matches its spec's path and query parameters. The Polymarket tools were also run against the live public APIs.
  • Several blocks sent a value saved for one operation to another one, because the executor merges stored inputs under the mapped params. Each case found is now cleared on the canvas, and the model's own argument is kept on Agent tool calls (toolCallArg). Each fix has a regression test that fails on the old code.
  • Path segments built from IDs, tickers and slugs (Kalshi, Polymarket, Temporal) now go through safeUrlPathSegment, so . and .. are rejected. Kalshi's signed path uses the same encoded value as the request URL.
  • Compatibility: no block type, subBlock, operation, tool, param or output id was renamed or removed, and no OAuth scope was added. Saved workflows send the same requests as before, except for the bug fixes below. Unsupported dropdown values are hidden for new selections, but saved blocks keep them.
  • Dagster and Fivetran needed no change.
  • Left for a product decision: Kalshi removed the /portfolio/orders write endpoints. Its spec says create, cancel and amend now return 410 Gone. The replacement (/portfolio/events/orders) uses a different trading model: a single-book bid/ask side, required time_in_force and self_trade_prevention_type, and no market orders. Translating yes/no + buy/sell orders into it changes what gets traded, so it is not guessed here. Kalshi Create/Cancel/Amend Order keep failing until that is decided.
  • Also left as is: SFTP and SSH blocks do not verify host keys. The SFTP client supports a pinned SHA-256 fingerprint, but no block field sets it. Adding the field is a product change.

Release notes

Polymarket

  • Get Trades, Get Positions, Get Activity, Get Leaderboard and Get Holders work again. Polymarket retired the Data API v1 and every call returned 410 Gone. These operations now use the Data API v2 and keep the same outputs.
  • These five operations now page with a cursor. A new optional Cursor field takes the new nextCursor output. A new hasMore output says whether another page exists. Polymarket no longer accepts Offset, and a non-zero Offset now fails with Polymarket's message pointing to Cursor.
  • Get Positions: the "Redeemable Only" and "Mergeable Only" filters map to Polymarket's position status, and Size Threshold maps to the minimum current size. Sort By has new Realized P&L, Total P&L and Last Activity options. Initial Value, Percent P&L, Title and Avg Price are no longer offered because Polymarket dropped them. Positions now also output their status.
  • Get Activity: Sort By Tokens and Cash are no longer offered; Polymarket sorts activity by timestamp only. An empty Start or End is now left out instead of being sent blank, a timestamp passed as text is accepted, a value that is not a Unix timestamp now fails with a clear error, and Start = 0 still returns the full history.
  • Get Leaderboard: a User Address now returns that wallet's rank on the selected board. Username lookup is no longer supported by Polymarket and now fails with a clear message instead of returning the whole board.
  • Get Market, Get Event and Get Series by ID reject an ID or slug of . or .. instead of calling a different endpoint.

Kalshi

  • Get Orders, Get Trades and Get Settlements no longer apply the Min/Max Timestamp entered for Get Fills in the same block.
  • Get Trades no longer filters by the Ticker entered for Get Market or Get Orderbook in the same block.
  • Amend Order no longer sends the fixed-point count entered for Create Order in the same block.
  • Get Settlements no longer fails when a Min/Max Timestamp value is empty.
  • Get Exchange Announcements is hidden for new selections because Kalshi removed the endpoint (it returns 404).
  • Order IDs, tickers and series tickers of . or .. are rejected before the request is signed.

SFTP

  • Upload Files no longer also writes the file content entered for Create File in the same block, and Create File no longer also uploads the files selected for Upload Files.
  • After switching Authentication Method to Password, a private key saved earlier is no longer sent; before, it was used instead of the password. Switching to Private Key no longer sends a saved password.
  • Remote paths containing a literal % (for example 100% done.csv) now work instead of being rejected as path traversal. Other escapes in the same path, such as %20, still decode.
  • A remote path ending in .. (for example /data/..) is now rejected like any other parent-directory path, so an upload or recursive delete can no longer reach the parent directory.
  • An uploaded file whose name contains encoded separators stays inside the target directory.
  • Upload file names are no longer percent-decoded a second time.

SSH

  • Create Directory no longer applies the permissions entered for Upload File in the same block. Directories are created with the default 0755 unless an agent passes permissions.
  • Upload File no longer applies the Overwrite switch from Move/Rename in the same block.
  • After switching Authentication Method to Password, a private key saved earlier is no longer sent; before, it was used instead of the password.
  • Command output with non-ASCII characters no longer shows broken characters (�) when a character spans two output chunks.
  • Create Directory now quotes the permissions value in the remote command.

SMTP

  • Security Mode "TLS" now requires STARTTLS. Before, if the server did not offer STARTTLS, the username, password and message were sent unencrypted. Such a server now fails the send instead.
  • A From Name containing quotes or angle brackets is now encoded correctly.

Jupyter

  • Create Session no longer sends the Create File type (for example file) as the session type when Session Type is empty, so sessions are created as notebook sessions again.

Temporal

  • Namespace, workflow ID, schedule ID, task queue, signal, query and update names of . or .. are rejected instead of calling a different endpoint. IDs that contain / still work.

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 18, 2026 8:59pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The changes since the previous review appear safe to merge.

Summary

This PR restores Polymarket data requests and fixes saved-input leaks, remote paths, SSH output, and SMTP encryption across the affected integrations.

  • Polymarket data tools use v2 requests and return cursors for the next page.
  • Block actions stop reusing saved values that belong to another action.
  • Integration URLs reject dot-only path values instead of treating them as navigation.
  • SFTP paths accept literal percent signs and reject parent-directory segments.
  • SMTP TLS mode requires encryption before it sends credentials or a message.
  • SSH command output keeps split UTF-8 characters readable and directory permissions quoted.
  • Kalshi settlements skip empty time filters and the removed announcement option is hidden.
  • The explicit-any baseline changes without changing runtime behavior.

Reviews (7) · Last reviewed commit: "fix(polymarket): mark the next-page curs..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 45 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/internal/sftp/client.ts Resolved
Comment thread apps/sim/lib/internal/sftp/client.ts Resolved
Comment thread apps/sim/blocks/blocks/sftp.ts Resolved
Comment thread apps/sim/blocks/blocks/jupyter.ts Resolved
Comment thread apps/sim/blocks/blocks/ssh.ts Resolved
Comment thread apps/sim/blocks/blocks/ssh.ts Resolved
@waleedlatif1
waleedlatif1 force-pushed the fix/validate-data-ops-remote branch from f53a748 to 37ec450 Compare November 18, 2026 18:43
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 46 files

Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 47 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/internal/sftp/client.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 47 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 force-pushed the fix/validate-data-ops-remote branch from 9c34c16 to fadeab9 Compare November 18, 2026 19:42
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 49 files

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 49 files

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 49 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 force-pushed the fix/validate-data-ops-remote branch from 7af7f9c to b9393ed Compare November 18, 2026 20:54
@waleedlatif1
waleedlatif1 merged commit dcc5369 into staging Nov 18, 2026
57 of 58 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/validate-data-ops-remote branch November 18, 2026 20:58

This branch was successfully deployed

1 active deployment
Preview — b9393ed1 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant